Kernel 2.6.20 added the new processor family CONFIG_MCORE2. The alsa-driver autoconf scripts don't check for this value and don't understand which processor type it is being built for. I have a patch that aliases Core 2 to the 686 architecture (just as the configure script does with all the Pentium family processors). Reproducible: Always Steps to Reproduce: 1. Configure kernel with CONFIG_MCORE2 2. Attempt to build alsa-driver Actual Results: See http://forums.gentoo.org/viewtopic-t-537554.html Expected Results: Successful compilation Kernel is configured as described.
Created attachment 111223 [details, diff] Patch to configure.in and configure Candidate patch; it patches both configure.in and the actual script since I don't know if running autoconf in the ebuild is reasonable or not. It produces some rather bad QA notices, however: * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc2_p3234/work/alsa-driver-1.0.14rc2_p3234/acore/memory_wrapper.c:40: warning: implicit declaration of function ‘VMALLOC_VMADDR’ [...] * QA Notice: Package has poor programming practices which may compile * but will almost certainly crash on 64bit architectures. * Function `pte_offset' implicitly converted to pointer at /var/tmp/portage/media-sound/alsa-driver-1.0.14_rc2_p3234/work/alsa-driver-1.0.14rc2_p3234/acore/memory_wrapper.c:46 [...]
Created attachment 112847 [details, diff] Working patch :) I've actually inserted this patch into an overlay ebuild and verified that it works. The QA warnings didn't appear this time.
Created attachment 113968 [details] media-sound/alsa-driver-1.0.14_rc1.ebuild Great work! Could you please remove the configure(.orig) patch? This is an updated ebuild: --- /usr/portage/media-sound/alsa-driver/alsa-driver-1.0.14_rc1.ebuild 2007-02-12 00:36:32.000000000 +0100 +++ alsa-driver-1.0.14_rc1.ebuild 2007-03-21 15:12:35.000000000 +0100 @@ -2,7 +2,7 @@ # Distributed under the terms of the GNU General Public License v2 # $Header: /var/cvsroot/gentoo-x86/media-sound/alsa-driver/alsa-driver-1.0.14_rc1.ebuild,v 1.9 2007/02/11 23:33:57 blubb Exp $ -inherit linux-mod flag-o-matic eutils multilib +inherit linux-mod flag-o-matic eutils multilib autotools MY_P="${P/_rc/rc}" S="${WORKDIR}/${MY_P}" @@ -103,6 +103,9 @@ convert_to_m "${S}/Makefile" sed -i -e 's:\(.*depmod\):#\1:' "${S}/Makefile" + + epatch ${FILESDIR}/mcore2.patch + eautoreconf } src_compile() {
Created attachment 114260 [details, diff] Patch without configure script included Okay. I need someone else to test if it works on rc1 since that version doesn't seem to compile for me. Also, shouldn't there be quotes around "${FILESDIR}/mcore2.patch"?
Seems someone made a similar patch for 1.0.14_rc3
