Bug 168127 – x11-drivers/nvidia-drivers-1.0.8776 doesn't compile against kernel 2.6.20

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description fredrik danerklint 2007-02-23 13:14:46 UTC]

You can't compile nvidia's drivers against kernel 2.6.20 since some definiton has been removed from the kernel sources.

==snip from interrupt.h in kernel 2.6.19==
/*
 * Migration helpers. Scheduled for removal in 1/2007
 * Do not use for new code !
 */
#define SA_INTERRUPT            IRQF_DISABLED
#define SA_SAMPLE_RANDOM        IRQF_SAMPLE_RANDOM
#define SA_SHIRQ                IRQF_SHARED
#define SA_PROBEIRQ             IRQF_PROBE_SHARED
#define SA_PERCPU               IRQF_PERCPU



Reproducible: Always




This patch fix so you can compile against 2.6.20.

--- NVIDIA.orig/usr/src/nv/nv.c 2007-02-23 13:27:25.000000000 +0100
+++ NVIDIA-Linux-x86-1.0-8776-pkg1/usr/src/nv/nv.c      2007-02-23 13:41:40.129501946 +0100
@@ -1802,7 +1802,7 @@
         }

         status = request_irq(nv->interrupt_line, nv_kern_isr,
-                             SA_INTERRUPT | SA_SHIRQ, "nvidia",
+                             IRQF_DISABLED | IRQF_SHARED, "nvidia",
                              (void *) nvl);
         if (status != 0)
         {

[Comment 1 fredrik danerklint 2007-02-23 13:17:03 UTC]

Created attachment 111041 [details, diff]
patch to allow nvidia-*-drivers to compile against kernel 2.6.20

[Comment 2 Paul Bredbury 2007-02-23 16:34:30 UTC]

This patch is *not* needed with git-sources-2.6.20-r14, because SA_SHIRQ etc. are still defined.

[Comment 3 Daniel Drake (RETIRED) 2007-03-25 19:43:14 UTC]

fredrik, which version are you using? Can you post the full compile error?

[Comment 4 Petteri Räty (RETIRED) 2007-03-25 19:57:02 UTC]

I haven't had any problems with nvidia drivers or 2.6.21_rc1 so more info is required.

[Comment 5 fredrik danerklint 2007-03-25 20:10:47 UTC]

(In reply to comment #3)
> fredrik, which version are you using? Can you post the full compile error?
> 

x11-drivers/nvidia-drivers-1.0.8776 and Linux athlon 2.6.20-rt8 #3 PREEMPT Sat Mar 3 18:00:56 CET 2007 i686 AMD Athlon(tm) XP 2500+ AuthenticAMD GNU/Linux

(In reply to comment #4)
> I haven't had any problems with nvidia drivers or 2.6.21_rc1 so more info is
> required.
> 

this neeeds to be fixed for all the old drivers! 
I don't think that the new drivers have this problem since nvidia has probably fixed it, but the old ones have.

[Comment 6 Daniel Drake (RETIRED) 2007-03-25 21:19:45 UTC]

fredrik, please reproduce this with a vanilla or gentoo-sources 2.6.20 kernel, and post the full compile error.

[Comment 7 fredrik danerklint 2007-03-25 22:02:00 UTC]

(In reply to comment #6)
== SNIP from interrupt.h in Kernel 2.6.20.3 ==
/*
 * Migration helpers. Scheduled for removal in 1/2007
 * Do not use for new code !
 */
#define SA_INTERRUPT            IRQF_DISABLED
#define SA_SAMPLE_RANDOM        IRQF_SAMPLE_RANDOM
#define SA_SHIRQ                IRQF_SHARED
#define SA_PROBEIRQ             IRQF_PROBE_SHARED
#define SA_PERCPU               IRQF_PERCPU


okey, it seems that Ingo Molnar's Realtime-patch takes this out from interrupt.h. 

However, when they _DO_ take them out, nv.c will still need to be patched.

[Comment 8 Chris Gianelloni (RETIRED) 2007-03-26 14:46:29 UTC]

Try 1.0.9631 and see if that works for you, please.

[Comment 9 Jakub Moc (RETIRED) 2007-09-04 01:09:21 UTC]

1.0.9639 works just fine here.