Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 165981 - mail-mta/netqmail: patches that edit conf-cc
Summary: mail-mta/netqmail: patches that edit conf-cc
Status: VERIFIED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Qmail Team (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-08 19:31 UTC by Allen Brooker (AllenJB)
Modified: 2007-02-12 18:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Brooker (AllenJB) 2007-02-08 19:31:40 UTC
While I fully realise that the use of QMAIL_PATCH_DIR on netqmail isn't officially supported, I'd like to suggest a change to the way the netqmail ebuild handles conf-cc.

The cause of this problem is that some patches edit conf-cc to add new requirements. For example, I'm using the popular jms1 combined patch (http://qmail.jms1.net), that changes conf-cc to: 
cc -O2 -DTLS -DEXTERNAL_TODO -I/usr/local/ssl/include -I/usr/kerberos/include

This obviously causes problems when Gentoo's ebuild replaces the entire file: echo -n "$(tc-getCC) ${CFLAGS}" > "${MY_S}/conf-cc"

I'd like to suggest that instead of replacing the entire file, the ebuild uses a patch (or sed, or whatever's the best way) to replace just the standard 'cc -O2' that the file contains by default.

I've not used sed before, but from looking at some documentation, something like the following would appear to do the trick: sed 's/cc -O2/$(tc-getCC) ${CFLAGS}/' <${MY_S}/conf-cc >${MY_S}/conf-cc

My guess is that something similar could also be done with the conf-ld file to also support a wider range of patches there.

There may be other alternatives which I've missed, which may solve the problem better.
Comment 1 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2007-02-11 18:55:08 UTC
Fixed in -1.05-r5, can you please test it? Thanks.
Comment 2 Allen Brooker (AllenJB) 2007-02-12 18:54:44 UTC
This appears to be working for me. Thanks very much. =)