Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 163567 - dev-util/nsis: patch for amd64 platforms
Summary: dev-util/nsis: patch for amd64 platforms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-24 10:03 UTC by Roie Marianer
Modified: 2007-01-27 22:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roie Marianer 2007-01-24 10:03:14 UTC 
Since NSIS only compiles 32-bit installers anyway, I added the option to compile for a 32-bit host. Now "makensis" works on my amd64 host, cross-compiling for a 32-bit Windows target.

Reproducible: Always

Steps to Reproduce:
diff -r -c nsis-2.23-src/SCons/Config/gnu nsis-2.23-works/SCons/Config/gnu
*** nsis-2.23-src/SCons/Config/gnu      Sat Nov 11 15:04:17 2006
--- nsis-2.23-works/SCons/Config/gnu    Mon Jan 22 15:13:52 2007
***************
*** 54,59 ****
--- 54,61 ----

  if defenv['DEBUG']:
        defenv.Append(CCFLAGS = '-g')
+ defenv.Append(CCFLAGS = '-m32')             # 32-bit host
+ defenv.Append(LINKFLAGS = '-m32')           # 32-bit host

  ### stub environment





Unfortunately, I don't know anything about the ebuild system other than from a user's perspective, so I don't know if (a) this patch even makes sense (though it definitely works for me), and (b) how to submit it properly, if it does. I'm submitting it here in case it interests anyone.
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2007-01-24 19:45:42 UTC 
I think nsis can be installed on a amd64 host without this patch, but I didn't had the time to test it. Try to install it as is - it installs only one native executable, namely makensis.
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2007-01-27 12:55:40 UTC 
Turns out you're right: the native code is not portable on 64-bit arches.

The patch and ~amd64 keyword have been added to nsis-2.23. Thanks!
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-27 21:08:04 UTC 
Please remember to submit this to upstream as it is very receptive!
strict aliasing and STRIP=no will be available at next version too!