Bug 161911 – tabcheck finds problems in the portage source

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Fabian Groffen 2007-01-13 17:08:11 UTC]

e.g.:

% find . -name "*.py" | xargs ./tabcheck.py 
./tests/portage_dep/test_dep_getcpv.py 15 '\t\tprefix_ops = ["<", ">", "=", "~", "!", "<=", \n'
./tests/portage_dep/test_isjustname.py 13 '\t\tcats = ( "", "sys-apps/", "foo/", "virtual/" )\n'


Reproducible: Always

Steps to Reproduce:
1. run tabcheck
2.
3.




see attached patch for a proposed "fix" that nukes some spaces, where tabs should be IMO.

[Comment 1 Fabian Groffen 2007-01-13 17:09:09 UTC]

Created attachment 106819 [details, diff]
diff to make tabcheck happy

see patch as a suggestion on how to make tabcheck happy.

[Comment 2 Brian Harring (RETIRED) 2007-01-13 17:31:51 UTC]

python -c 'import tabnanny;tabnanny.check("/usr/lib/portage/pym")' # is a bit easier in the future ;)

[Comment 3 Alec Warner (RETIRED) 2007-01-13 19:31:25 UTC]

(In reply to comment #2)
> python -c 'import tabnanny;tabnanny.check("/usr/lib/portage/pym")' # is a bit
> easier in the future ;)
> 

Tabcheck is run from tarball.sh with pretty much 'constant' arguments, and it checks stuff outside of pym/ (which the tests are not in, I might add ;))

Fixed in svn, btw ;)

[Comment 4 Zac Medico 2007-01-14 23:35:51 UTC]

This has been released in 2.1.2.