removal of linux/config.h has broken usb-pcw-re build. according to several other bug reports for other packages which used to rely on linux/config.h this can be sed'ed out of the files in which it occurs. possibly we might need to retain compatibility back to previous versions; per that case #IF the #INCLUDE for linux/config.h. Apparently the change was made in kernel 2.6.18. This include is in pcw-uncompress.h and pwc.h in this package. Perhaps should be fixed upstream, however: Please find attached a patch which WFM ~~ this REMOVES the include for linux/config.h in the two files that are affected. Portage 2.1.2_rc4-r1 (default-linux/x86/2006.1/desktop, gcc-3.4.6, glibc-2.5-r0, 2.6.19-gentoo-r2X86_gentoo_19-3 i686) ================================================================= System uname: 2.6.19-gentoo-r2X86_gentoo_19-3 i686 AMD Athlon(tm) 64 Processor 3000+ Gentoo Base System version 1.12.8 Last Sync: Tue, 26 Dec 2006 20:00:01 +0000 dev-java/java-config: 1.3.7, 2.0.31 dev-lang/python: 2.3.6, 2.4.4 dev-python/pycrypto: 2.0.1-r5 sys-apps/sandbox: 1.2.18.1 sys-devel/autoconf: 2.13, 2.61 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.17 sys-devel/gcc-config: 1.3.14 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.17-r2 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-O3 -march=athlon-xp" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb /usr/share/config /var/bind" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/splash /etc/terminfo" CXXFLAGS="-O3 -march=athlon-xp" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig distlocks metadata-transfer sandbox sfperms strict" GENTOO_MIRRORS="http://gentoo.chem.wisc.edu/gentoo/ ftp://gentoo.cites.uiuc.edu/pub/gentoo/ http://gentoo.cites.uiuc.edu/pub/gentoo/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/ http://mirror.datapipe.net/gentoo" LINGUAS="en en_GB" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="3dfx 3dnow X a52 aac acpi aim alsa alsa_cards_ac97-codec alsa_cards_intel8x0 alsa_cards_usb-audio alsa_pcm_plugins_adpcm alsa_pcm_plugins_alaw alsa_pcm_plugins_asym alsa_pcm_plugins_copy alsa_pcm_plugins_dmix alsa_pcm_plugins_dshare alsa_pcm_plugins_dsnoop alsa_pcm_plugins_empty alsa_pcm_plugins_extplug alsa_pcm_plugins_file alsa_pcm_plugins_hooks alsa_pcm_plugins_iec958 alsa_pcm_plugins_ioplug alsa_pcm_plugins_ladspa alsa_pcm_plugins_lfloat alsa_pcm_plugins_linear alsa_pcm_plugins_meter alsa_pcm_plugins_mulaw alsa_pcm_plugins_multi alsa_pcm_plugins_null alsa_pcm_plugins_plug alsa_pcm_plugins_rate alsa_pcm_plugins_route alsa_pcm_plugins_share alsa_pcm_plugins_shm alsa_pcm_plugins_softvol aoss apache2 apm arts audiofile avi berkdb bitmap-fonts bluetooth bzip2 cairo cdparanoia cdr cli cracklib crypt cups curl dbm dbus directfb divx4linux dlloader dri dvd dvdr dvdread eds elibc_glibc emboss encode evo exif fam fbcon ffmpeg firefox flac foomaticdb fortran gdbm gif gnome gphoto2 gpm gstreamer gtk gtk2 gtkhtml hal iconv icq imagemagick imlib input_devices_evdev input_devices_joystick input_devices_keyboard input_devices_mouse input_devices_wacom ipv6 isdnlog jabber java javascript jpeg jpeg2k kde kdeenablefinal kernel_linux ldap lesstif libg++ libwww linguas_en linguas_en_GB lm_sensors lua mad mbox mikmod milter mime mmap mmx mng motif mozilla mp3 mpeg msn musicbrainz mysql ncurses nls nptl nptlonly nsplugin ogg oggvorbis opengl oscar oss pam pcre pda pdf pdflib perl php png povray ppds pppd pulseaudio python qt qt3 qt4 quicktime readline reflection samba sdl session sharedmem sndfile sockets speex spell spl sse sse2 ssl svg svga tcpd threads tiff truetype truetype-fonts type1-fonts udev unicode usb userland_GNU v4l v4l2 video_cards_fbdev video_cards_fglrx video_cards_radeon video_cards_v4l video_cards_vesa video_cards_vga video_cards_vmware vorbis win32codecs wmf x86 xine xml xml2 xorg xscreensaver xv xvid yahoo zlib" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Created attachment 105019 [details, diff] diff to patch the affected files and remove from the build WFM - diff -Naur to remove the references to linux/config.h
Comment on attachment 105019 [details, diff] diff to patch the affected files and remove from the build Okay -- I'm no expert, but I believe you need patch -p0 to apply this to the build files.
You need to produce a patch which can be unconditionally applied and will work on any kernel version (therefore it can be sent upstream). e.g. something like #include <linux/version.h> #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18) #include <linux/config.h> #endif
Maintainers, this is your 1 week advance warning for 2.6.19 going stable.
Just checked in a version that works for me with 2.6.19. Please re-open if you have problems.
Reopening as this is not fixed in the stable tree. Either backport the fix to the stable version, make the stable version bail out on 2.6.19, remove all stable keywords from this package, or file a bug for a newer version to be marked stable. Also, your patch is not entirely correct -- please take my advice in comment #3 otherwise you will have to patch this *again* in a couple of releases time when autoconf.h is moved away.
(In reply to comment #6) > Reopening as this is not fixed in the stable tree. Either backport the fix to > the stable version, make the stable version bail out on 2.6.19, remove all > stable keywords from this package, or file a bug for a newer version to be > marked stable. > > Also, your patch is not entirely correct -- please take my advice in comment #3 > otherwise you will have to patch this *again* in a couple of releases time when > autoconf.h is moved away. I already posted a bug about getting the newest ebuild stable ASAP, if arch teams have problems with this I'll have to mask it. Since I hardly have a clue about development of the kernel I would be happy if you could give me a few hints what else to include instead for whatever was supposed to be in config|autoconf.h. #include <myterious_future_header> does not work for me.
I already advised you on how the code should look in comment #3. You do not need to include any headers on new kernels.
newer version is now stable, thanks
