Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158688 - app-misc/sl ebuild cleanup (respect LDFLAGS and compiler, use linguas_ja instead of cjk)
Summary: app-misc/sl ebuild cleanup (respect LDFLAGS and compiler, use linguas_ja inst...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mamoru KOMACHI (RETIRED)
Depends on:
Blocks: ldflags
  Show dependency tree
Reported: 2006-12-20 15:16 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-08-09 21:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Ebuild patch (sl-ebuild.patch,1.64 KB, patch)
2006-12-20 15:16 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-12-20 15:16:03 UTC
Just stumbled across this randomly, and seen that it uses the cjk useflag just to add the Japanese manpage; as that is not always good (people like me might have cjk enabled but don't ask for proper Japanese support), I've looked at the ebuild, so I'm attaching a cleanup diff.

 - cjk useflag is replaced by linguas_ja (that translates to have "ja" in the LINGUAS variable);
 - you can drop the !ppc-macos dependency on nkf, if Fabian cannot make nkf to build on main tree, he can fix it for prefix or use package.use.mask;
 - virtual/libc is a moot dependency, just drop it;
 - using make to compile a single .c file in an executable is an overkill, especially since the Makefile does not add anything extra to the compile line; the current emake call also does not respect user-defined LDFLAGS or a crosscompiler, instead the use of gcc directly allows a simpler src_unpack and respect all the variables;
 - added a debug useflag to add -DDEBUG to the CFLAGS;
 - quoted all the variables that are user-defined.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-12-20 15:16:29 UTC
Created attachment 104470 [details, diff]
Ebuild patch
Comment 2 Mamoru KOMACHI (RETIRED) gentoo-dev 2006-12-30 04:35:36 UTC
Absolutely. Thanks Diego, I applied the patch to existing ebuild, except
that it doesn't require nkf anymore and uses iconv to convert its manpage.
(if source encoding is fixed we usually don't need to use nkf, unless
source documents contain invalid characters)