Bug 154969 – [PATCH] pycurl-7.15.4.2 threading bug breaks bzr, etc

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Donnie Berkholz (RETIRED) 2006-11-12 22:15:07 UTC]

There's a small bug in pycurl that breaks bzr, among other things. I got it from the Debian bug in the URL.

diff -urN pycurl-7.15.4.2.orig/src/pycurl.c pycurl-7.15.4.2/src/pycurl.c
--- pycurl-7.15.4.2.orig/src/pycurl.c   2006-11-09 20:53:44.000000000 -0800
+++ pycurl-7.15.4.2/src/pycurl.c    2006-11-09 20:54:03.000000000 -0800
@@ -416,7 +416,7 @@
 
 static int pycurl_ssl_mutex_lock(void **m)
 {
-    return PyThread_acquire_lock(*((PyThread_type_lock *) m), 1);
+    return !PyThread_acquire_lock(*((PyThread_type_lock *) m), 1);
 }
 
 static int pycurl_ssl_mutex_unlock(void **m)

[Comment 1 Daniel Black (RETIRED) 2006-12-08 18:47:34 UTC]

fixed in 7.15.4.2-r1. I've also added pycurl-7.15.5.1 (that included this fix). Thanks Donnie