Bug 1547 – Artistic Style (astyle) ebuild

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Y-z 2002-04-05 03:07:35 UTC]

Hi,

Attached the astyle ebuild script. In src_{compile,install}() I manually
cd into ${WORKDIR} -- dunno if that can be solved more elegantly...

I think dev-lang would be an appropriate place,

Regards,

Eyez

[Comment 1 Y-z 2002-04-05 03:20:05 UTC]

Can't get Mozilla to attach a file...So here it is:

# Copyright 1999-2002 Gentoo Technologies, Inc.
# Distributed under the terms of the GNU General Public License, v2 or later
# Maintainer: Eyez <[e-mail]>
# /space/gentoo/cvsroot/gentoo-x86/skel.ebuild,v 1.4 2002/03/12 16:05:09 tod Exp

ZIP="astyle_${PV}.zip"
S=${WORKDIR}/${P}
DESCRIPTION="Artistic Style is a reindenter and reformatter of C++, C and Java
source code."
SRC_URI="http://prdownloads.sourceforge.net/astyle/${ZIP}"
HOMEPAGE="http://astyle.sourceforge.net"
DEPEND=">=app-arch/unzip-5.42"

src_compile() {
        cd ${WORKDIR}
        emake || die
}

src_install () {
        cd ${WORKDIR}
        into /usr
        dobin astyle
        dodoc astyle.html astyle_release_notes.html license.html
}

[Comment 2 Tod M. Neidt (RETIRED) 2002-04-12 00:30:34 UTC]

Hi!

Glanced at your ebuild and it looks pretty good. I would suggest the category
dev-util. This is a new ebuild triage

Some comments:

1.The reason you have to cd to ${WORKDIR} is that whoever archive the zip file
didn't include a top_level directory in the archive, i.e just a list of files
was archived.  You could just remove the ${P} from the ${S}= line and then
remove the 'cd ${WORKDIR}' from src_compile.

2.  The html documentation should be installed with dohtml instead of dodoc. 
See /usr/lib/portage/bin/dohtml


These changes, especially the dohtml one, will lessen the load on the developer
who is eventually assigned this ebuild for evaluation and will expedite its
inclusion into the portage tree.

 

[Comment 3 Tod M. Neidt (RETIRED) 2002-04-12 00:32:48 UTC]

Hi!

One more thing :)

dodoc INSTALL.TXT

[Comment 4 Y-z 2002-04-12 09:28:26 UTC]

He! Neither Konqueror nor Mozilla is able to upload attachments!

New ebuild, with proposed changes:

# Copyright 1999-2002 Gentoo Technologies, Inc.
# Distributed under the terms of the GNU General Public License, v2 or later
# Maintainer: Eyez <[e-mail]>
# /space/gentoo/cvsroot/gentoo-x86/skel.ebuild,v 1.4 2002/03/12 16:05:09 tod Exp

ZIP="astyle_${PV}.zip"
S=${WORKDIR}
DESCRIPTION="Artistic Style is a reindenter and reformatter of C++, C and Java
source code."
SRC_URI="http://prdownloads.sourceforge.net/astyle/${ZIP}"
HOMEPAGE="http://astyle.sourceforge.net"
DEPEND=">=app-arch/unzip-5.42"

src_compile() {
        emake || die
}

src_install () {
        into /usr
        dobin astyle
        dohtml astyle.html astyle_release_notes.html license.html
        dodoc INSTALL.TXT
}

[Comment 5 Tod M. Neidt (RETIRED) 2002-04-12 16:20:59 UTC]

Hi!

I'll take this for a spin :)

[Comment 6 Karl Trygve Kalleberg (RETIRED) 2002-04-24 15:29:17 UTC]

Available as dev-util/astyle-1.15.3