Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 153439 - media-libs/allegromp3 removal request
Summary: media-libs/allegromp3 removal request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard: REMOVED
Keywords:
Depends on:
Blocks: 107226 117482 172058
  Show dependency tree
 
Reported: 2006-10-30 06:58 UTC by Evil Compile Person
Modified: 2007-07-29 06:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to correct gcc 4 error (almp3_gcc-4.patch,116.24 KB, patch)
2007-03-24 14:42 UTC, Tom Macdonald
Details | Diff
allegromp3-2.0.2-fix.patch (allegromp3-2.0.2-fix.patch,823 bytes, patch)
2007-04-22 20:02 UTC, Stian Skjelstad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evil Compile Person 2006-10-30 06:58:17 UTC
gcc -c -Wall -O2 -march=pentium -fomit-frame-pointer -finline-functions -ffast-math -Idecoder -Iinclude src/almp3.c -o obj/linux/static/almp3.o
src/almp3.c: In function 'almp3_create_mp3':
src/almp3.c:334: error: invalid lvalue in assignment
src/almp3.c:351: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:359: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:382: error: invalid lvalue in assignment
src/almp3.c: In function 'almp3_poll_mp3':
src/almp3.c:781: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:789: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c: In function 'almp3_create_sample_from_mp3':
src/almp3.c:1002: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:1010: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c: In function 'almp3_create_mp3stream':
src/almp3.c:1265: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:1273: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c: In function 'almp3_poll_mp3stream':
src/almp3.c:1655: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
src/almp3.c:1663: warning: pointer targets in passing argument 1 of 'almp3_get_big_endian' differ in signedness
make: *** [almp3.o] Error 1

!!! ERROR: media-libs/allegromp3-2.0.2 failed.

Gentoo Base System version 1.6.14
Portage 2.1.1 (default-linux/x86/2006.1, gcc-4.1.1, glibc-2.4-r3, 2.6.16.16 i686)
=================================================================
System uname: 2.6.16.16 i686 AMD Athlon(tm) 64 Processor 3200+
Last Sync: Sun, 29 Oct 2006 06:30:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: [Not Present]
dev-lang/python:     2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf /etc/terminfo"
CXXFLAGS="-O2 -march=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig buildpkg distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="ftp://212.219.56.134/sites/www.ibiblio.org/gentoo/ ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo"
LINGUAS=""
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X berkdb bitmap-fonts cli cracklib crypt cups dlloader dri elibc_glibc fortran gdbm gpm iconv input_devices_evdev input_devices_keyboard input_devices_mouse ipv6 isdnlog kernel_linux libg++ ncurses nls nptl nptlonly pam pcre perl ppds pppd python readline reflection session spl ssl tcpd truetype-fonts type1-fonts udev unicode userland_GNU video_cards_apm video_cards_ark video_cards_ati video_cards_chips video_cards_cirrus video_cards_cyrix video_cards_dummy video_cards_fbdev video_cards_glint video_cards_i128 video_cards_i740 video_cards_i810 video_cards_imstt video_cards_mga video_cards_neomagic video_cards_nsc video_cards_nv video_cards_rendition video_cards_s3 video_cards_s3virge video_cards_savage video_cards_siliconmotion video_cards_sis video_cards_sisusb video_cards_tdfx video_cards_tga video_cards_trident video_cards_tseng video_cards_v4l video_cards_vesa video_cards_vga video_cards_via video_cards_vmware video_cards_voodoo xorg zlib"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, MAKEOPTS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Tom Macdonald 2007-03-24 14:42:10 UTC
Created attachment 114249 [details, diff]
Patch to correct gcc 4 error

This patch should correct the compiling error with gcc4. Basically in src/almp3.c on lines 344 and 382 it removes the (char*) bit. This is my first ever patch, so that's why I'm telling you this in case someone needs to do it again. :-D
Cheers
Tom
Comment 2 Stian Skjelstad 2007-04-22 18:23:08 UTC
Something went very wrong in that diff.

diff -ur orgdir newdir > my.patch

Should do the job very fine
Comment 3 Stian Skjelstad 2007-04-22 20:02:06 UTC
Created attachment 117016 [details, diff]
allegromp3-2.0.2-fix.patch

Is this what you had in mind. I saw that the ebuild converts all the files into unix newline formats.
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2007-05-12 23:40:41 UTC
upstream is gone.  i can't find a valid source.

is there any reason we should keep this package around?
Comment 5 Stian Skjelstad 2007-05-13 21:40:29 UTC
Nothing that depends on it?
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-05-20 21:17:14 UTC
Sending to treecleaners.
Comment 7 Ryan Hill (RETIRED) gentoo-dev 2007-06-06 04:20:38 UTC
(In reply to comment #5)
> Nothing that depends on it?

Doesn't look like it.

dirtyepic@tycho ~ $ grep -R "allegromp3" /var/cache/edb/dep/usr/portage/*
dirtyepic@tycho ~ $
Comment 8 Raúl Porcel (RETIRED) gentoo-dev 2007-06-26 17:38:45 UTC
++ then
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2007-06-26 19:13:23 UTC
Is there a sensible alternative to it?
Comment 10 Christian Heim (RETIRED) gentoo-dev 2007-07-01 15:23:23 UTC
(In reply to comment #9)
> Is there a sensible alternative to it?

What about media-sound/lame ?

++ from my side for punting it.
Comment 11 Raúl Porcel (RETIRED) gentoo-dev 2007-07-01 17:21:14 UTC
Well, sound maintains this, so they should give the okay or mask it theirselves.

drac? :)
Comment 12 Ryan Hill (RETIRED) gentoo-dev 2007-07-01 18:26:30 UTC
as a member of the sound team i heartily endorse the removal of this event or product.
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2007-07-01 19:22:57 UTC
go ahead.
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2007-07-02 16:54:39 UTC
# Samuli Suominen <drac@gentoo.org> (02 Jul 2007)
# Orphaned library. Masked for removal in 30 days. Bug 153439.
media-libs/allegromp3
Comment 15 Raúl Porcel (RETIRED) gentoo-dev 2007-07-09 16:00:02 UTC
reassigning to drac, since treecleaner doesn't have nothing to do here
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2007-07-29 06:18:42 UTC
removed.