Bug 152017 – Streamlined dosed

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Tim Cera 2006-10-19 17:02:02 UTC]

There is an option (-i) with newer sed programs that will make sed edit the file in place.  Eliminates a couple lines of code in dosed.

[Comment 1 Tim Cera 2006-10-19 17:03:59 UTC]

Created attachment 100056 [details]
dosed which edits the target file in place

[Comment 2 SpanKY 2006-10-19 17:25:38 UTC]

this was done on purpose because -i isnt posix, but i think we're to the point now where so many ebuilds use it that sed-4 w/-i support is a hard requirement

so patch should be fine

[Comment 3 Zac Medico 2006-10-19 23:05:41 UTC]

Thanks, it now uses sed -i in svn r4762.

[Comment 4 Fabian Groffen 2006-10-20 00:19:27 UTC]

Zach, your applied patch is wrong:
sed -ie "${mysed}" "${y}"

This means all files that you touch get backupped with "e" as extension.  Either use -i -e or -ei as in the original patch.

[Comment 5 Zac Medico 2006-10-20 00:40:59 UTC]

Thanks, now I have `sed -i -e "${mysed}" "${y}"` in svn r4763.

[Comment 6 Tim Cera 2006-10-20 15:09:48 UTC]

(In reply to comment #4)
> Zach, your applied patch is wrong:
> sed -ie "${mysed}" "${y}"
> 
> This means all files that you touch get backupped with "e" as extension. 
> Either use -i -e or -ei as in the original patch.
> 

I apologize for this.  I had other changes in dosed that I pulled out because I thought they were too radical and I obviously didn't test the final version which I ended up posting.

Tim

[Comment 7 Zac Medico 2006-10-20 16:37:26 UTC]

This has been released in 2.1.2_pre3-r6.