Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149653 - sys-block/nbd-2.8.6 fails with -Wl,--as-needed
Summary: sys-block/nbd-2.8.6 fails with -Wl,--as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2006-09-30 13:52 UTC by Donnie Berkholz (RETIRED)
Modified: 2006-09-30 14:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Donnie Berkholz (RETIRED) gentoo-dev 2006-09-30 13:52:52 UTC 
files/nbd-2.8.2-gznbd.patch should have LDFLAGS after the object.

+   $(CC) $(CFLAGS) $< -o $@ $(LDFLAGS)

rather than before

+   $(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
Comment 1 SpanKY gentoo-dev 2006-09-30 13:56:29 UTC 
erm, not quite ... problem is that LDFLAGS should not contain libs
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-30 13:58:52 UTC 
Fix it up however you want, this worked for me. Make a new LIBS var if you like for -lz, and tag that after.
Comment 3 SpanKY gentoo-dev 2006-09-30 14:02:46 UTC 
fixed patch to use LDLIBS and to use implicit make rules (which handles LDFLAGS/LDLIBS ordering)
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-30 14:41:39 UTC 
Great, thanks!