Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 148863 - dev-libs/clearsilver-0.10.3 version bump and python 2.5 patch
Summary: dev-libs/clearsilver-0.10.3 version bump and python 2.5 patch
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Julien Allanos (RETIRED)
Depends on:
Blocks: python-2.5 149001
  Show dependency tree
Reported: 2006-09-23 15:41 UTC by Marien Zwart (RETIRED)
Modified: 2006-09-28 15:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments and PyMem/PyObject fixes. (clearsilver-0.10.3-python-2.5-compat.patch,1.35 KB, patch)
2006-09-23 15:42 UTC, Marien Zwart (RETIRED)
Details | Diff
ebuild including this patch (clearsilver-0.10.2-r1.ebuild,1.51 KB, text/plain)
2006-09-25 03:14 UTC, Lukasz Ligowski
build log (screenlog.0,51.56 KB, text/plain)
2006-09-26 10:20 UTC, Lukasz Ligowski
config.log (config.log,40.33 KB, text/plain)
2006-09-26 10:23 UTC, Lukasz Ligowski

Note You need to log in before you can comment on or make changes to this bug.
Description Marien Zwart (RETIRED) gentoo-dev 2006-09-23 15:41:43 UTC
clearsilver 0.10.2 does not work with python 2.5. I bumped it to 0.10.3 and patched it to work:

- its contains a hardcoded list of python versions, to which I added 2.5 (and 2.6 while I was at it). But see bug 144580, it would probably be better to fix that one instead.
- it calls PyMem_DEL to free things allocated with PyObject_NEW. This has always been invalid but only actually stopped working in python 2.5.

This should probably go upstream as well but I have not found upstreams bug tracker yet. If someone else does please put the patch on there or tell me where it is. If this bug is fixed in portage before someone finds their bug tracker I will inform upstream through email.
Comment 1 Marien Zwart (RETIRED) gentoo-dev 2006-09-23 15:42:25 UTC
Created attachment 97901 [details, diff] and PyMem/PyObject fixes.
Comment 2 Lukasz Ligowski 2006-09-25 03:14:39 UTC
Created attachment 98010 [details]
ebuild including this patch

Hmm I've created an ebuild which includes this patch but it does not compile module for python 2.5 but for 2.4... I put this as an attachment so you can check if I did something wrong.
Comment 3 Marien Zwart (RETIRED) gentoo-dev 2006-09-25 03:33:20 UTC
The patch touches, so you will have to rerun at least autoconf for it to work. Adding "inherit autotools" and running "eautoreconf" at the end of src_unpack should do the trick.
Comment 4 Julien Allanos (RETIRED) gentoo-dev 2006-09-25 04:57:46 UTC
I'll report it to upstream, and I'll include some patches into clearsilver-0.10.3 asap.
Comment 5 Lukasz Ligowski 2006-09-25 14:01:48 UTC
(In reply to comment #3)
> The patch touches, so you will have to rerun at least autoconf for
> it to work. Adding "inherit autotools" and running "eautoreconf" at the end of
> src_unpack should do the trick.

It works almost perfectly, clearsilver compiles now with python 2.5, but puts *.so in / instead of python2.5/site-packages, I do not know autotools very well so I dont know why...

Comment 6 Marien Zwart (RETIRED) gentoo-dev 2006-09-25 15:50:20 UTC
That does not happen here. Can you provide a build log? config.log might also be interesting.
Comment 7 Lukasz Ligowski 2006-09-26 10:20:08 UTC
Created attachment 98145 [details]
build log

Build log.
Comment 8 Lukasz Ligowski 2006-09-26 10:23:28 UTC
Created attachment 98147 [details]

PYTHON_SITE is not set...
Comment 9 Marien Zwart (RETIRED) gentoo-dev 2006-09-26 12:30:11 UTC
Huh. I do not see how that could happen unless PYTHON_SITE is set to the empty string in your (or really portage's) environment. Can you check if that happened somehow? As far as I can tell the configure script should always set PYTHON_SITE to something else than the empty string unless it's already set in the environment.
Comment 10 Lukasz Ligowski 2006-09-27 03:46:32 UTC
Ok. I changed my ebuild to compile 10.3 version and it works. In changelog from 10.2 to 10.3 they write that:

Change 2006/01/26 by blong@blong

	Fix bug introduced in 0.10.2 version of configure (bad sh syntax
	for PYTHON_SITE) and try another tact for getting site locations
	that should work with /usr/lib64 variations.
Comment 11 Julien Allanos (RETIRED) gentoo-dev 2006-09-27 15:20:27 UTC
Please test clearsilver-0.10.3.
Comment 12 Lukasz Ligowski 2006-09-28 11:31:33 UTC
(In reply to comment #11)
> Please test clearsilver-0.10.3.

Works fine. :)
Comment 13 Julien Allanos (RETIRED) gentoo-dev 2006-09-28 15:24:17 UTC
Then closing.