Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 146485 - media-libs/faad2-2.5 version bump request
Summary: media-libs/faad2-2.5 version bump request
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Sound Team
URL: http://www.audiocoding.com
Whiteboard:
Keywords:
Depends on:
Blocks: 154063
  Show dependency tree
 
Reported: 2006-09-05 18:01 UTC by ScytheMan
Modified: 2007-10-14 08:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
faad2-2.5.ebuild - requires patch, following (faad2-2.5.ebuild,1.04 KB, text/plain)
2006-10-13 12:45 UTC, Armando Di Cianno
Details
patch to remove broken/left-over bmp (beep media player) code from faad2-2.5 (faad2-2.5-bmp-bad.patch,2.59 KB, patch)
2006-10-13 12:46 UTC, Armando Di Cianno
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Armando Di Cianno 2006-10-13 12:45:37 UTC
Created attachment 99580 [details]
faad2-2.5.ebuild - requires patch, following

I did not test the with xmms option, since I mainly only use faad2 support from ffmpeg.
Comment 2 Armando Di Cianno 2006-10-13 12:46:42 UTC
Created attachment 99581 [details, diff]
patch to remove broken/left-over bmp (beep media player) code from faad2-2.5

required for ebuild, above in attachment list
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2006-11-29 03:20:38 UTC
The 2.5 version of faad2 is now in portage. Unfortunately I was not able to use your patch, as both BMP & XMMS are no longer in the tree both should be removed. I also took the liberty of patching a missing include.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-11-29 03:49:22 UTC
A second.
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-11-29 03:58:02 UTC
I missed this bug up to now, but I already got requests for this before.
Faad2 legal standing is currently bad: it used to be GPL-2 licensed, but now it's rather a GPL-2+advertising, that's in turn GPL-2 incompatible (remember that BSD-4 licenses are incompatible with GPL-2 because of the advertising clause, and was thus mitigated in BSD-3).
As GPL-2 licensed packages currently use faad2 (ffmpeg, mplayer, vlc, xine), having 2.5 as primary alternative is not something I feel we should do.

I'm going to see if FSF would be able to take care of this issue so we don't have to stay in the grey area forever.
Comment 6 Armando Di Cianno 2006-11-29 09:38:55 UTC
Tony Vroon:
- Just to be clear, the patch *removes*  BMP and XMMS support, which was broken anyway.

General:
- This package is part of a solution towards, admittedly not fully grokked, an issue I have with ffmpeg not recognizing that it can handle audio from 3g2/p files, which is often amr.  When understood more, I'll definitely file an appropriate bug/patch for ffmpeg, but this package may be *required* for that, so I hope the licensing stuff get resolved. :-\
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2006-12-03 05:17:47 UTC
(In reply to comment #6)
> so I hope the licensing stuff get resolved. :-\

Well, this is probably moot, there's no intention whatsoever to fix the licensing  issues from Nero side... Go read

http://www.hydrogenaudio.org/forums/index.php?showtopic=35535&st=0

And, this _is_ GPL incompatible:

> Recently, one of the components used in our software, an AAC decoding
> library also licensed under the GPL called FAAD2, added this clause
> to their source code files:
>
> ** Software using this code must display the following message
> ** visibly in the
> ** software:
> ** "FAAD2 AAC/HE-AAC/HE-AACv2/DRM decoder 
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2006-12-03 05:17:47 UTC
(In reply to comment #6)
> so I hope the licensing stuff get resolved. :-\

Well, this is probably moot, there's no intention whatsoever to fix the licensing  issues from Nero side... Go read

http://www.hydrogenaudio.org/forums/index.php?showtopic=35535&st=0

And, this _is_ GPL incompatible:

> Recently, one of the components used in our software, an AAC decoding
> library also licensed under the GPL called FAAD2, added this clause
> to their source code files:
>
> ** Software using this code must display the following message
> ** visibly in the
> ** software:
> ** "FAAD2 AAC/HE-AAC/HE-AACv2/DRM decoder © Ahead Software, www.nero.com"
> ** in, for example, the about-box or help/startup screen.
>
> Other than that, they use the standard GPL version 2 text.
>
> While we have no problem abiding to that request, I would like to know
> if that change doesn't render said library GPL-incompatible and,
> therefore, incompatible with our software.

Yes, that's definitely GPL-incompatible.  It's an additional
restriction.  It's not required by section 1's "appropriate copyright
notice" provision, because section 1 would permit such a notice to be
extrinsic to the software itself -- on the box or CD or associated
files, for instance.  And it's not required by (2)© because it doesn't
meet most of the (2)© requirements (interactive, already displays,
no-warranty, license is GPL, GPL can be found where).

Can you fork off an earlier version of the library, or ask that they
change that requirement to a request?

-- 
-Dave "Novalis" Turner
GPL Compliance Engineer
Free Software Foundation

(paste from http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=35535&view=findpost&p=314491)
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2007-10-14 08:08:31 UTC
*** Bug 195800 has been marked as a duplicate of this bug. ***