Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 145568 - dev-java/fop-0.20.5-r6 build.xml uses automagical tests to determine whether build optional stuff
Summary: dev-java/fop-0.20.5-r6 build.xml uses automagical tests to determine whether ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-30 02:47 UTC by Vlastimil Babka (Caster) (RETIRED)
Modified: 2006-09-10 13:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
new patch for build.xml (0.20.5-buildxml.patch,1.92 KB, patch)
2006-08-30 02:48 UTC, Vlastimil Babka (Caster) (RETIRED)
Details | Diff
patch for fop's ebuild (fop-0.20.5-r6.ebuild.patch,719 bytes, patch)
2006-08-30 02:50 UTC, Vlastimil Babka (Caster) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-08-30 02:47:09 UTC
It tests presence of the following on classpath:
jimi (sun-jimi), jai (sun-jai-bin), trax (xalan), jdk14, jce

This is bad because jimi and jai are controlled by useflags (linking appropriate jars into lib/ dir based on the flag), but the autodetection can mess with it because ant can be using jai itself, and that can result in (with USE="-jai" for fop):
- java-strict is on, but the autodetection will still see jai on classpath when doing the test (-Dbuild.sysclasspath=ignore doesn't affect this, sadly), during compiling jai will be hidden and build will fail
- java-strict is off, it will build jai support because it's in ant's classpath, but it won't be recorded as dep in fop's package.env

One solution can be to put ignoresystemclasspath="true" parameter in <available> tags in build.xml used to test jai and jimi presence. This will ensure that jai and jimi support will be checked only in lib/ dir, not on classpath ant uses. This could be done even without patching, by running xml-rewrite.py from ebuild. But since there's already a build.xml patch, I expanded it to do the following:

Instead of testing for jdk14 and jce, it enables is unconditionally. Also changed the dep from || (jdk1.4 jdk-1.3) to just jdk-1.4.
Same with the trax testing, it's just enabled, because xalan is unconditional dep anyway.
Tests for jai and jimi are removed and the associated properties are not set in build.xml at all. Ebuild passes these properties based on useflags.
No automagical detection is left :)
Comment 1 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-08-30 02:48:37 UTC
Created attachment 95444 [details, diff]
new patch for build.xml
Comment 2 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-08-30 02:50:14 UTC
Created attachment 95447 [details, diff]
patch for fop's ebuild
Comment 3 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-09-10 13:56:32 UTC
Released in fop-0.20.5-r7