Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 141445 - xpak,py xsplit function return logic issue
Summary: xpak,py xsplit function return logic issue
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 136244
  Show dependency tree
 
Reported: 2006-07-22 16:25 UTC by Chris White (RETIRED)
Modified: 2006-07-23 15:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris White (RETIRED) gentoo-dev 2006-07-22 16:25:19 UTC
Noted in sys-apps/portage-2.1.1_pre2-r1 and -r3991 SVN.  xsplit has the following code:

 splits = xsplit_mem(mydat)
        if not splits:
                return

and later on down:

        myfile.write(splits[1])
        myfile.close()
        return

This should be return false/true to be able to distinguish failure/success of the function.
Comment 1 Zac Medico gentoo-dev 2006-07-22 16:40:34 UTC
Thanks, in svn r4006 it now returns False on failure and True on success.
Comment 2 Zac Medico gentoo-dev 2006-07-23 15:00:23 UTC
This has been released in 2.1.1_pre3-r4.