Bug 138600 – Can't change some colors with color.map

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Damien Thébault 2006-06-30 10:40:48 UTC]

With the 2.1.1_pre1-r5 portage version, some colors changed.
I noticed the red to yellow change for "selected" packages (removal).
I tried to change this with the "color.map" file, but it didn't work.
I put all colors to "fuchsia" : some lines of the "emerge -pvC autoconf" changed, but the yellow ones didn't.

% emerge --info
Portage 2.1.1_pre1-r5 (default-linux/x86/2006.0, gcc-4.1.1/vanilla, glibc-2.4-r3, 2.6.15.6 i686)
=================================================================
System uname: 2.6.15.6 i686 AMD Athlon(tm) MP 2400+
Gentoo Base System version 1.12.0
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [disabled]
dev-lang/python:     2.4.3-r1
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.4-r2
dev-util/confcache:  0.4.2-r1
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/gcc-config: 2.0.0_rc1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -mtune=athlon-mp -march=athlon-mp -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/eselect/compiler /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -mtune=athlon-mp -march=athlon-mp -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig buildsyspkg collision-protect confcache distlocks metadata-transfer parallel-fetch sandbox sfperms"
GENTOO_MIRRORS="http://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/"
LANG="fr_FR@euro"
LC_ALL="fr_FR@euro"
LINGUAS="fr"
MAKEOPTS="-j 3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/overlays/portage /usr/local/overlays/xgl-overlay /usr/local/overlays/xgl-coffee /usr/portage/local/layman/sunrise"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowext X a52 aac alsa apm avi berkdb bitmap-fonts bzip2 cairo cdparanoia cdr cli crypt cups curl dbus djvu dlloader dri dts dvd dvdr dvdread eds emboss encode ext2 ext3 fat ffmpeg firefox flac foomaticdb gcj gdbm gif glitz gnome gnutls gpm gstreamer gtk gtk2 hal imagemagick imlib ipv6 isdnlog jikes jpeg libg++ libwww lzo mad matroska mikmod mmx mmxext mng motif mp3 mp4 mpeg ncurses nls nptl nptlonly ntfs nvidia ogg openal opengl pam pcre pdflib perl pic pie png pppd python qt qt3 qt4 quicktime readline reflection reiser4 reiserfs samba sdl session slang smp spell spl sse ssl svg tcpd tga theora threads truetype truetype-fonts type1-fonts udev usb userlocales v4l v4l2 vorbis win32codecs x264 xinerama xml xml2 xorg xrandr xv xvid zlib elibc_glibc input_devices_evdev input_devices_joystick input_devices_keyboard input_devices_mouse kernel_linux linguas_fr userland_GNU video_cards_nv video_cards_nvidia video_cards_vesa video_cards_vga video_cards_v4l"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Damien Thébault 2006-06-30 10:42:50 UTC]

Created attachment 90541 [details, diff]
emerge_colorize_remove.diff

Remove use of "colorize" from /usr/bin/emerge and use "yellow()" and "green()".

[Comment 2 Zac Medico 2006-06-30 10:48:13 UTC]

Your patch is backwards.  We want to use colorize everywhere, so that none of the colors have to be hard coded.  Think of color.map like a CSS stylesheet.  It will be used to map meanings to colors.  If you want, submit a patch the replaces hard coded colors with the colorize function.

[Comment 3 Damien Thébault 2006-06-30 15:51:25 UTC]

Created attachment 90574 [details, diff]
emerge.colorize1.diff

Using "GOOD", "WARN" and "BAD" seems better for me too :)

I changed some of the hard coded colors (mainly red ones with "***") with the colorize function, and it looks good.

[Comment 4 Zac Medico 2006-06-30 16:31:50 UTC]

Thanks, that's much better.

[Comment 5 Zac Medico 2006-07-01 12:58:30 UTC]

This is fixed in svn r3745.

[Comment 6 Zac Medico 2006-07-01 16:12:36 UTC]

This has been released on 2.1.1_pre2.