Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 138415 - Emerging app-misc/when fails when FEATURES=test
Summary: Emerging app-misc/when fails when FEATURES=test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 17:31 UTC by James Rowe
Modified: 2007-01-22 00:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
when-fix_test_environment.patch (when-fix_test_environment.patch,728 bytes, patch)
2006-06-28 17:32 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2006-06-28 17:31:27 UTC
Emerging app-misc/when fails when FEATURES=test, because the tool requires
a semi-setup work environment and attempts to call the binary without a path
from the Makefile.

  The attached patch fixes both these problems, and allows the building of
when if FEATURES=test is set.

Thanks


James
Comment 1 James Rowe 2006-06-28 17:32:03 UTC
Created attachment 90391 [details, diff]
when-fix_test_environment.patch
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2007-01-19 04:49:14 UTC
we can't touch ${HOME} from an ebuild, it violates our sandbox environment.  i've added a test restriction to the ebuild instead.
Comment 3 James Rowe 2007-01-20 06:49:32 UTC
First, thanks for getting around to this bug.

> ------- Comment #2 from dirtyepic@gentoo.org  2007-01-19 04:49 -0800 -------
> we can't touch ${HOME} from an ebuild, it violates our sandbox environment.
> i've added a test restriction to the ebuild instead.

  Please reconsider this change.  Using HOME isn't a sandbox violation,
because it doesn't touch any files outside of portage's temp directory.

  Portage creates a package specific HOME for use by ebuilds.  Take a look
at /usr/lib/portage/pym/portage.py to see the implementation or just add an
'echo $HOME' to an ebuild to see it in action ;)  Paludis also handles this
in ebuild/builtin_init.bash and pkgcore in pkgcore/ebuild/ebd.py, admittedly
I haven't tried either of those just read the source.

Thanks,

James
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2007-01-22 00:11:15 UTC
well, learn something new every day. ;)

i've undone my change and applied your patch.  thanks.