Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 136197 - debug sources paths are wrong with installsources & splitdebug
Summary: debug sources paths are wrong with installsources & splitdebug
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 136244
  Show dependency tree
 
Reported: 2006-06-09 07:55 UTC by Olivier Crete (RETIRED)
Modified: 2006-08-04 14:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against 2.1 branch svn (fix-installsources-2.1svn.patch,2.10 KB, patch)
2006-06-09 12:17 UTC, Olivier Crete (RETIRED)
Details | Diff
new version (fix-installsources-2.1svn.patch,2.16 KB, patch)
2006-06-11 18:43 UTC, Olivier Crete (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Crete (RETIRED) gentoo-dev 2006-06-09 07:55:16 UTC
the debugedit/installsources stuff has to be run before splitdebug. I'm attaching a patch against 2.0.54-r2.. I can make one against 2.1, but I'm not sure which cvs/svn tree is the right one.. Btw, is there still any development being done on the 2.0.x branch, if so, I can make a patch against that tree too, wherever it is.

Also, installsources should also be tested in the nostrip case, since it is very likely that we want to see the source if we have all the debug info in the binary.. So the nostrip test should not be at the top of prepstrip.
Comment 1 Zac Medico gentoo-dev 2006-06-09 08:20:09 UTC
2.1 final has just been released, so 2.0.x should be dieing now.  For 2.1, a patch against svn+ssh://svn.gentoo.org/var/svnroot/portage/main/branches/2.1/ would be nice (its currently identical to main/trunk/).
Comment 2 Olivier Crete (RETIRED) gentoo-dev 2006-06-09 12:17:52 UTC
Created attachment 88785 [details, diff]
patch against 2.1 branch svn

Oops, I forgot to attach the patch. Anyways, I've ported it to portage 2.1 and there it is.
Comment 3 SpanKY gentoo-dev 2006-06-11 12:38:40 UTC
quoting of the LHS is not needed when using [[ ]]

instead of updating each case in the strip loop, just do
[[ -n ${NOSTRIP} ]] && continue

you also need to make sure NOSTRIP is sane and that the outside env isnt going to let a bogus value leak in
Comment 4 Olivier Crete (RETIRED) gentoo-dev 2006-06-11 18:43:47 UTC
Created attachment 88950 [details, diff]
new version

I've added an unset NOSTRIP. We can't just continue because we dont call debugedit on the .a files.
Comment 5 Zac Medico gentoo-dev 2006-08-03 22:31:50 UTC
Thanks, this is in svn r4136,
Comment 6 Zac Medico gentoo-dev 2006-08-04 14:00:56 UTC
This has been released in 2.1.1_pre4-r3.