Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 135398 - python-missingos module is no longer needed in portage.
Summary: python-missingos module is no longer needed in portage.
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 115839
  Show dependency tree
 
Reported: 2006-06-03 09:01 UTC by Andrei F.
Modified: 2006-06-07 05:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei F. 2006-06-03 09:01:32 UTC
Hello. I suggest removing the python-missingos modules from the portage tarball because it is no longer needed. Plus of that it makes bootstraping portage from different CHOSTs (ex. from i386-pc-linux-gnu to i686-pc-linux-gnu) very difficult. thanks.
Comment 1 Zac Medico gentoo-dev 2006-06-03 10:05:24 UTC
I've removed the compilation of python bytecodes and the missingos module from the ebuild.
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2006-06-04 22:29:47 UTC
It's definitely not needed? As far as I know, it is required for older versions of OS X. (10.3 and later has lchown?)
Comment 3 Zac Medico gentoo-dev 2006-06-04 22:59:32 UTC
The python docs specifically state "Availability:Macintosh, Unix. New in version 2.3" for lchown(). The last time I checked, they are using >=python-2.3 on ppc-macos.  If not, their depgraph would already by broken by portage's >=python-2.3 dependency.
Comment 4 Zac Medico gentoo-dev 2006-06-04 23:12:55 UTC
Just in case, I'm going to add it back into the ebuild and make it conditional on userland_Darwin.
Comment 5 Zac Medico gentoo-dev 2006-06-04 23:24:46 UTC
Nevermind.  I see that missingos has been conditional on ! use userland_Darwin, so  apparently it's not a problem...
Comment 6 Jason Stubbs (RETIRED) gentoo-dev 2006-06-06 18:56:25 UTC
Hmm.. fair enough. When was it for then? 2.2, I guess.. I have seen cases where a python that was meant to have lchown didn't though. That's the main reason why I made it always compiled. Could probably circumvent that just by aliasing lchown to a noop if it isn't available...
Comment 7 Zac Medico gentoo-dev 2006-06-06 19:24:31 UTC
I've just noticed that the 2.0.51.22-r3 ebuild detects the absence of lchown and builds it only if necessary:

python_has_lchown() {
	[ "$(python -c 'import os; print "lchown" in dir(os)')" = "True" ]
}

That seems like a nice approach.  The idea of having a silent noop kind of bothers me...
Comment 8 Jason Stubbs (RETIRED) gentoo-dev 2006-06-07 04:11:12 UTC
Bug #42461 and bug #89434 are examples of what I was talking about, but after reading through them you're probably right about the lack of noise.
Comment 9 Zac Medico gentoo-dev 2006-06-07 05:51:30 UTC
I've add a noisy noop lchown in svn r3466-r3467.  It will only be used if python has no lchown and missingos is unavailable.  That way, if one of those bugs happens again, the user can simply rebuild python after seeing the warning message.