132943 – sandbox bashrc looks very wrong

Bug 132943 - sandbox bashrc looks very wrong

Summary: sandbox bashrc looks very wrong

Status:	RESOLVED INVALID

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Sandbox (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Sandbox Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-05-10 13:18 UTC by ferret
Modified:	2006-05-17 06:13 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description ferret 2006-05-10 13:18:03 UTC

I don't really have the time or knowledge to test this at the moment, but I happened to glance at /usr/share/sandbox/sandbox.bashrc :

if [[ -n ${LD_PRELOAD} && ${LD_PRELOAD} != *$SANDBOX_LIB* ]] ; then
        export LD_PRELOAD="${SANDBOX_LIB} ${LD_PRELOAD}"
elif [[ -z ${LD_PRELOAD} ]] ; then
        export LD_PRELOAD="${SANDBOX_LIB}"
fi

The if statement looks bad. '*' is pathname expansion in bash, but it's trying to do string matching or something here by the look of it.

Comment 1 Ed Catmur 2006-05-16 16:26:46 UTC

It's correct. [[ ]] tests have their own semantics for globbing. See bash(1).

Comment 2 Martin Schlemmer (RETIRED) gentoo-dev

2006-05-17 06:13:47 UTC

(In reply to comment #1)
> It's correct. [[ ]] tests have their own semantics for globbing. See bash(1).
> 

Ditto - bug is invalid.