Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 131844 - [PATCH] x11-libs/libzvt patch for --Wl,--as-needed support
Summary: [PATCH] x11-libs/libzvt patch for --Wl,--as-needed support
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
: 135773 143085 (view as bug list)
Depends on: 147550
Blocks: as-needed
  Show dependency tree
Reported: 2006-04-30 17:24 UTC by TGL
Modified: 2007-03-04 22:39 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

files/libzvt-2.0.1-as-needed.patch (libzvt-2.0.1-as-needed.patch,1.20 KB, patch)
2006-04-30 17:24 UTC, TGL
Details | Diff
libzvt-2.0.1-ebuild.patch (libzvt-2.0.1-ebuild.patch,382 bytes, patch)
2006-04-30 17:27 UTC, TGL
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description TGL 2006-04-30 17:24:29 UTC
libzvt has unresolved symbols provided by libutil. This prevent building x11-libs/vte with -Wl,--as-needed. This patch fixes that.
Comment 1 TGL 2006-04-30 17:24:51 UTC
Created attachment 85883 [details, diff]
Comment 2 TGL 2006-04-30 17:27:54 UTC
Created attachment 85884 [details, diff]

patch for the ebuild
Comment 3 TGL 2006-05-14 05:09:58 UTC
Sent upstream:
Comment 4 Ernestas Liubarskij 2006-06-08 11:59:12 UTC
*** Bug 135773 has been marked as a duplicate of this bug. ***
Comment 5 Ernestas Liubarskij 2006-06-08 12:01:04 UTC
Your patch fixed it; thanks, TGL.
Comment 6 Daniel Gryniewicz (RETIRED) gentoo-dev 2006-06-30 20:30:07 UTC
I have libzvt and gnomesu (the only thing I have that deps on it) both built with --as-needed, and neither has a problem.  vte doesn't depend on libzvt (and I have that built with --as-needed too).  Which version of binutils do you have installed?
Comment 7 Ernestas Liubarskij 2006-07-01 00:42:27 UTC
I had "sys-devel/binutils:  2.16.93", now I have 2.17 installed. As I can see, vte doesn't depend on libzvt, but it somehow didn't want to build because of "/usr/lib/ undefined reference to `login_tty'". See my bug 135773
gnome-terminal-2.14.2 depends on vte.
Comment 8 TGL 2006-07-02 03:44:11 UTC
(In reply to comment #6)
> vte doesn't depend on libzvt 

There is some automagic crap in the of vte:

# If we can find libzvt on the system, set up to build a variant of "reflect"
# which uses it.
if pkg-config --exists libzvt-2.0 ; then
	PKG_CHECK_MODULES(ZVT,[gtk+-2.0 libzvt-2.0])

Probably it should be made configurable, or maybe even simply patched out.

As for the unresolved symbols not being reported as an error on your system, it depends on the binutils version: it's a check which has been introduced by a 2.16.9x version (i don't remember which one exactly).
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2006-08-07 07:27:01 UTC
*** Bug 143085 has been marked as a duplicate of this bug. ***
Comment 10 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2006-09-01 18:36:06 UTC
There is a patch at [1] to remove libzvt from vte. It was applied upstream. The patch can be modified a bit to apply to vte-0.12.2 (the failed hunk is in ChangeLog)

Comment 11 Rémi Cardona (RETIRED) gentoo-dev 2007-03-04 22:39:11 UTC
Fixed upstream. :) Thanks