Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 131378 - using "blacklist foo" in /etc/modules.d/ files causes generate-modprobe.conf to die
Summary: using "blacklist foo" in /etc/modules.d/ files causes generate-modprobe.conf ...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
: 188914 234676 (view as bug list)
Depends on:
Blocks: udev-meta
  Show dependency tree
 
Reported: 2006-04-26 13:54 UTC by Greg Kroah-Hartman (RETIRED)
Modified: 2008-08-13 20:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Kroah-Hartman (RETIRED) gentoo-dev 2006-04-26 13:54:14 UTC
"blacklist foo" is a valid modules.conf file syntax, and is required in order
to handle blacklisting modules from being automatically loaded by udev at 
coldplug time, or when some devices are plugged in after booting.

My limited scripting foo could not find the error in the generate-modprobe.conf
file to try to fix this myself, sorry.
Comment 1 SpanKY gentoo-dev 2006-04-26 14:06:33 UTC
valid syntax according to who ?  generate-modprobe.conf doesnt care about synatx, it's "modprobe.old" from the modutils package that is barfing on the syntax ... baselayout basically does:
# cat /etc/modules.d/* > /etc/modprobe.conf

in other words, you should be talking to Keith Owens / Rusty Russell about this
Comment 2 Greg Kroah-Hartman (RETIRED) gentoo-dev 2006-04-26 16:11:41 UTC
Well, why would modprobe.old care about new style modprobe commands (like 
blacklist)?

Maybe the script needs to not call the .old programs if you aren't using
any 2.4 kernels.

Either way, we need to have a mechanism to get the blacklist lines into
the modprobe.conf file, and since we aren't supposed to be editing
that file by hand, but rather using these tools...
Comment 3 SpanKY gentoo-dev 2006-04-26 17:24:55 UTC
/etc/modules.d/ is for old modprobe

/etc/modprobe.d/ is for new modprobe

so if you're putting stuff into /etc/modules.d/ then it needs to be compatible with the old modprobe
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2006-04-26 19:29:57 UTC
I do not have a /etc/modprobe.d/ on my system, what package creates this and puts the same
stuff that currently is in /etc/modules.d/ into it (assuming that we want the same kind of stuff in
it...)
Comment 5 SpanKY gentoo-dev 2006-04-26 22:08:15 UTC
nothing owns either directory ... that's sort of the point ... packages drop in files as they need them

new modprobe from module-init-tools automatically scans /etc/modprobe.d/ and reads /etc/modprobe.conf

old modprobe from modutils only reads /etc/modules.conf ... since that isnt very friendly for updating on the fly, many distros use /etc/modules.d/ to hold package-specific files which are then collected and placed into /etc/modules.conf

since most packages still use old style /etc/modules.d/ syntax, and valid syntax has changed from old modprobe to new modprobe, baselayout now parses out the bits that the new modprobe accepts (like the "alias" keywords)

you still havent said who declared "blacklist foo" to be valid syntax ... nowhere in the modules.conf nor modprobe.conf manpages can i find reference to the "blacklist" keyword
Comment 6 Greg Kroah-Hartman (RETIRED) gentoo-dev 2006-04-26 22:25:21 UTC
The blacklist option is described in 'man modprobe.conf' under the "COMMANDS" section.
Comment 7 SpanKY gentoo-dev 2006-04-26 22:34:22 UTC
must have had duplicate man windows of modules.conf open or i'm retarded and cant type ... sorry about that

at any rate, you should be putting your blacklist stuff in /etc/modprobe.d/, *not* in /etc/modules.d/ ... /etc/modules.d/ is for old linux-2.4 modutils
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-08-14 21:45:12 UTC
*** Bug 188914 has been marked as a duplicate of this bug. ***
Comment 9 Panagiotis Christopoulos (RETIRED) gentoo-dev 2008-08-13 20:56:17 UTC
*** Bug 234676 has been marked as a duplicate of this bug. ***