Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 128605 - sys-devel/distcc --as-needed fix
Summary: sys-devel/distcc --as-needed fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Lisa Seelye (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2006-04-02 23:36 UTC by Ben Skeggs
Modified: 2006-04-15 09:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix library ordering in Makefile.in (distcc-2.18.3-as-needed.patch,558 bytes, patch)
2006-04-02 23:38 UTC, Ben Skeggs
Details | Diff
Patch to ebuild (distcc-2.18.3-r7.ebuild.patch,514 bytes, patch)
2006-04-02 23:39 UTC, Ben Skeggs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Skeggs 2006-04-02 23:36:57 UTC
sys-devel/distcc-2.18.3-r7 fails to build with -Wl,--as-needed in LDFLAGS.

Patches on the way.
Comment 1 Ben Skeggs 2006-04-02 23:38:35 UTC
Created attachment 83786 [details, diff]
Fix library ordering in Makefile.in
Comment 2 Ben Skeggs 2006-04-02 23:39:06 UTC
Created attachment 83787 [details, diff]
Patch to ebuild
Comment 3 Lisa Seelye (RETIRED) gentoo-dev 2006-04-03 04:30:22 UTC
Can you post emerge info too please and where the build fails.
Comment 4 Lisa Seelye (RETIRED) gentoo-dev 2006-04-03 04:38:30 UTC
Further(In reply to comment #1)
> Created an attachment (id=83786) [edit]
> Fix library ordering in Makefile.in
> 

What exactly does this patch do? How/In what way does it solve the problem?
Comment 5 Ben Skeggs 2006-04-03 08:11:35 UTC
See http://www.gentoo.org/proj/en/qa/asneeded.xml.  In particular, the section titled "The importance of linking order".

The patch just moves the distcc monitor object files *before* the libraries they link with.  When --as-needed is used, failure to do so will cause "missing symbol" errors.  But, the link I posted explains it better than I do.
Comment 6 Steev Klimaszewski (RETIRED) gentoo-dev 2006-04-04 02:39:00 UTC
This patch is only needed when the gnome useflag is in use
Comment 7 Lisa Seelye (RETIRED) gentoo-dev 2006-04-15 09:11:23 UTC
Sorry it took so long, I was waiting on feedback from another dev. Fixed in CVS.