Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 122783 - net-firewall/iptables-1.3.x has redundant conditional dependency
Summary: net-firewall/iptables-1.3.x has redundant conditional dependency
Status: RESOLVED DUPLICATE of bug 120233
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-14 04:50 UTC by Giacomo Graziosi
Modified: 2006-02-17 01:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Giacomo Graziosi 2006-02-14 04:50:58 UTC 
From the ebuild:

DEPEND="virtual/os-headers
        extensions? ( virtual/linux-sources )"


but then:
ictway ~ # emerge iptables -pv

These are the packages that I would merge, in order:

Calculating dependencies ...done!
[ebuild  N    ] sys-kernel/gentoo-sources-2.6.15-r5  USE="-build -doc -symlink" 209 kB
[ebuild   R   ] net-firewall/iptables-1.3.5  USE="ipv6 -extensions -static" 0 kB

Total size of downloads: 209 kB
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-02-14 04:56:07 UTC 
iptables needs kernel sources to build extensions, don't understand what are you complaining about.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-02-14 05:03:16 UTC 
Heh, OK - I see now... :) Not that it would change anything from the point of dependencies, but 

extensions? ( virtual/linux-sources )

is redundant there, linux-info eclass depends on virtual/linux-sources regardless.
Comment 3 SpanKY gentoo-dev 2006-02-14 10:07:59 UTC 
it isnt a bug in the ebuild, the DEPEND is correct

if the kernel team wants to drop the DEPEND from the eclass, that's their choice
Comment 4 Henrik Brix Andersen 2006-02-14 10:19:24 UTC 
The functionality in linux-info.eclass depends on having a kernel source tree available...
Comment 5 SpanKY gentoo-dev 2006-02-14 10:31:40 UTC 
... but it prevents people from conditionally using the eclass ... you could make an internal eclass var:
if [[ ${LINUX_INFO_CONDTIONAL} != "yes" ]] ; then
    DEPEND="..."
fi
and in the ebuild:
LINUX_INFO_CONDITIONAL="yes"
inherit linux-info

not that it really matters to me either way ... kill the bug if you want
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2006-02-17 01:58:20 UTC 
This is a dupe anyway...

*** This bug has been marked as a duplicate of 120233 ***