Bug 118455 – repoman should validate use? conditional and atom prefix/postfix syntax

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Zac Medico 2006-01-09 13:00:00 UTC]

While working with the savior branch I discovered some invalid conditional syntax that is not discovered by repoman (portage-2.1_pre3-r1).  For example, DEPEND="!X? ( !svga ( !fbcon ( media-libs/libsdl ) ) )" has missing '?' characters on !svga and !fbcon but repoman fails to notice (the actual depstring is from games-emulation/gnuboy-1.0.3).

[Comment 1 Zac Medico 2006-01-09 15:25:04 UTC]

Luckily, it seems that games-emulation/gnuboy-1.0.3 is the only offending ebuild in the whole tree. :)

[Comment 2 Zac Medico 2006-01-10 17:01:08 UTC]

Broadening the scope a little, repoman (portage-2.1_pre3-r1) fails to detect inappropriate atom prefix/postfix combinations such as use of the * postfix with prefixes other than = and !=.

[Comment 3 Zac Medico 2006-03-23 22:29:16 UTC]

"foo? bar", which should be "foo? ( bar )", is not detected.

[Comment 4 Vlastimil Babka (Caster) (RETIRED) 2006-12-05 02:58:12 UTC]

(In reply to comment #2)
> Broadening the scope a little, repoman (portage-2.1_pre3-r1) fails to detect
> inappropriate atom prefix/postfix combinations such as use of the * postfix
> with prefixes other than = and !=.
> 

Yes, please. Then we wouldn't have bugs like bug 157197.

[Comment 5 Zac Medico 2006-12-16 15:34:32 UTC]

(In reply to comment #2)
> Broadening the scope a little, repoman (portage-2.1_pre3-r1) fails to detect
> inappropriate atom prefix/postfix combinations such as use of the * postfix
> with prefixes other than = and !=.

Fixed in svn r5240 and r5262:5264.

(In reply to comment #3)
> "foo? bar", which should be "foo? ( bar )", is not detected.

Fixed in svn r5305.

[Comment 6 Zac Medico 2006-12-16 17:16:22 UTC]

This has been released in 2.1.2_rc3-r6.