Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 118190 - xfmedia 0.9.1 won't compile with dbus 0.60
Summary: xfmedia 0.9.1 won't compile with dbus 0.60
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-07 08:50 UTC by whitehawk
Modified: 2006-04-08 14:24 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description whitehawk 2006-01-07 08:50:38 UTC
xfmedia 0.9.1 won't compile with dbus 0.60.

There's a patch at http://medusa.tutka.fi/~pasi/xfmedia-0.9.1-dbus-0.60-fix.patch

and also recieved this info in #xfce@freenode
[17:38:13] <pov> I'd guess Brian will fix it
Comment 1 whitehawk 2006-01-07 08:51:40 UTC
I recieved the patch location from pov also on #xfce@freenode
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2006-01-07 10:37:23 UTC
This is kind of related to bug #94331 because while xfmedia did add a DBUS dependancy, it added a wrong dependancy. You can't just depend on ANY dbus available. You need to specify a version because of API changes.
Comment 3 whitehawk 2006-01-07 12:21:29 UTC
Also, I trioed to compile it with USE=-dbus but it still died, so the implementation is useless, it does nothing. It should pass some configure option not to add dbus support.
Comment 4 whitehawk 2006-01-08 04:47:44 UTC
A working ebuild. Uses the patch above, and the dbus use flag works here.

http://medusa.tutka.fi/~pasi/xfmedia-0.9.1-r2.ebuild

(It's not my work)
Comment 5 Bernard Cafarelli gentoo-dev 2006-01-09 05:37:28 UTC
Emerge went fine with this patch (on dbus 0.60) on ~amd64.

Can we specify specific versions of dbus in use_dbus in src_unpack?
Comment 6 Pasi Orovuo 2006-01-09 10:08:48 UTC
I don't think it's really necessary. The patch, though redundant, has no effect on pre 0.60 DBus.
Comment 7 matthew.cline 2006-01-30 18:17:21 UTC
I got an error when trying to emerge xfmedia-0.9.1-r1. (I think) this is related to this bug report:

lude/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/exo-0.3 -I/usr/include/xfce4 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/taglib -O2 -march=athlon-xp -mtune=athlon-xp -pipe -fomit-frame-pointer -MT xfmedia-settings.o -MD -MP -MF ".deps/xfmedia-settings.Tpo" -c -o xfmedia-settings.o `test -f 'settings.c' || echo './'`settings.c; \
then mv -f ".deps/xfmedia-settings.Tpo" ".deps/xfmedia-settings.Po"; else rm -f ".deps/xfmedia-settings.Tpo"; exit 1; fi
remote.c: In function `xfmedia_remote_init':
remote.c:493: error: `DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT' undeclared (first use in this function)
remote.c:493: error: (Each undeclared identifier is reported only once
remote.c:493: error: for each function it appears in.)
make[2]: *** [xfmedia-remote.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/var/tmp/portage/xfmedia-0.9.1-r1/work/xfmedia-0.9.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/xfmedia-0.9.1-r1/work/xfmedia-0.9.1'
make: *** [all] Error 2

!!! ERROR: xfce-extra/xfmedia-0.9.1-r1 failed.
Call stack:
  ebuild.sh, line 1894:   Called dyn_compile
  ebuild.sh, line 941:   Called src_compile
  ebuild.sh, line 1609:   Called xfce42_src_compile

!!! (no error message)
!!! If you need support, post the topmost build error, and the call stack if relevant.


Comment 8 Pasi Orovuo 2006-02-01 11:41:13 UTC
Yes, that's the error the patch addresses.
Comment 9 Botykai Zsolt 2006-02-15 00:00:50 UTC
OK I set up an overlay with this ebuild (and patch), so cfmedia compiled, but I still can't use xfmedia-remote --pause (and other remote options):
** (process:5587): WARNING **: Failed to open a connection to the D-BUS session bus.  Please ensure that the session bus is running. (0: Unable to determine the address of the message bus)

Anyone knows how to resolve this?
Comment 10 A. Person 2006-04-05 10:41:24 UTC
Any chance of this fix making it into portage any time soon?
Comment 11 Daniel Ostrow (RETIRED) gentoo-dev 2006-04-08 14:24:17 UTC
Fixed as of 0.9.1-r2. Sorry about the delay I wanted to wait for upstream to patch it.