Apart from the placement of the pkgconfig files, the existing ebuilds aren't ${ROOT} enabled, yet.
I'll fix the pkgconfigs shortly. What all needs to have a ROOT in front of it? Just install directories?
I'm thinking that maybe it's smarter to move these files into /usr/$(get_libdir)/qt4/pkgconfig instead of /usr/lib/pkgconfig and then adding that path to the PKG_CONFIG_PATH environment variable when qt is installed. Thoughts?
(In reply to comment #1) > What all needs to have a ROOT in front of it? > Just install directories? Basically yes. Portage utility functions/scripts/variables like dodir, insinto, $D etc. should handle it transparently, so only where / is directly referenced in ebuilds or build scripts have it hardcoded instead using $prefix, etc. it is needed. Usually I fix the ebuilds I come across and leave possible patches to those who use an alternative root path. (In reply to comment #2) > Thoughts? As long as it gets found I don't care. Just to note that none of the applications I have installed doesn't use the standard pkgconfig directory.
I noticed that graphviz installs in /usr/lib/graphviz/pkgconfig, but maybe that's an ebuild mistake. The only reason I'm a little afraid to use /usr/lib/pkgconfig is that the filenames aren't versioned (QtCore.pc, QtNetwork.pc...) so if/when Qt5 comes out what if the names conflict? But, as well, if we use the environment variable approach, then it won't work for processes not started by the user (daemons and such). I guess I'll just stick to /usr/lib/pkgconfig for now, and we can always fix it later if we need to.
(In reply to comment #4) > I noticed that graphviz installs in /usr/lib/graphviz/pkgconfig, but maybe > that's an ebuild mistake. Probably. I have graphviz-2.6 installed and the files are in /usr/lib/pkgconfig. > The only reason I'm a little afraid to use /usr/lib/pkgconfig is that the > filenames aren't versioned (QtCore.pc, QtNetwork.pc...) so if/when Qt5 comes > out what if the names conflict? I'd say it's up to Trolltech to provide foo-x.pc. That's how it's handled by other projects, too. Personally I don't understand why they didn't do so with qmake etc. either, instead leaving it to their userbase to make sure the correct binary is chosen.
pkgconfig files have been fixed (4.1.0-r1 anyway). ROOT is still unfixed.
Carlo, if you want to tackle the $ROOT feel free. I'm always afraid I'm going to mess something up.
should not be moved. i think linking is the better way, becouse /usr/qt/* is not that much lfs compliant. maybe the version coliding could be reduced with subdirs like /usr/bin/qt4/ (like it is already for libs and includes)
pkg config path is cared for and the proposed $ROOT change is invalid, based on a missunderstanding on my side, what folks intended to achieve.
