Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 113487 - app-laptop/toshset (new ebuild)
Summary: app-laptop/toshset (new ebuild)
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard: sunrise-removal
Keywords: EBUILD, InOverlay
Depends on: weaver
Blocks:
  Show dependency tree
 
Reported: 2005-11-24 10:34 UTC by Christoph Burger-Scheidlin
Modified: 2018-06-07 18:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (toshset-1.71.ebuild,589 bytes, text/plain)
2005-11-24 10:36 UTC, Christoph Burger-Scheidlin
Details
Diff to patch the Makefile to allow CFLAGS from /etc/make.conf (toshset-1.71-Makefile.diff,335 bytes, patch)
2005-11-24 10:37 UTC, Christoph Burger-Scheidlin
Details | Diff
toshset-1.72.ebuild (toshset-1.72.ebuild,777 bytes, text/plain)
2007-04-12 16:43 UTC, Andrey Kislyuk (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Burger-Scheidlin 2005-11-24 10:34:45 UTC
The toshset utility can be used to modify certain features of Toshiba laptops. 
See http://www.schwieters.org/toshset/. This ebuild is for version 1.71. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Christoph Burger-Scheidlin 2005-11-24 10:36:33 UTC
Created attachment 73509 [details]
ebuild
Comment 2 Christoph Burger-Scheidlin 2005-11-24 10:37:50 UTC
Created attachment 73510 [details, diff]
Diff to patch the Makefile to allow CFLAGS from /etc/make.conf
Comment 3 Andrey Kislyuk (RETIRED) gentoo-dev 2007-04-12 16:43:36 UTC
Created attachment 116080 [details]
toshset-1.72.ebuild

A better ebuild.

Still complains about pre-stripped files, but I have no time to track down a strip command in a package I don't even use.

Latest version will be available in sunrise (http://overlays.gentoo.org/proj/sunrise/browser/sunrise/app-laptop/toshset). This will be a dependency for sys-power/acpi-support.

NB: The ubuntu version adds a BIG patch so package functionality is probably substantially changed.

Finally, ubuntu notes a pciutils dependency. I didn't check if the package actually depends on it and whether it's a depend or rdepend. Please check.
Comment 4 George Shapovalov (RETIRED) gentoo-dev 2007-12-15 22:17:14 UTC
Andrey:
ebuild (in sunrise) look good, except it would be nice to split a long sed line in src_unpack (with \ at the end of line after the sed command) for little bit more readability. Plus, of course, the issues you mention with that dependency should be verified before ebuild is committed. 
As for the patch, it is for you to decide. I'd suggest adding in the original (as upstream intended) version first, unless you are sure that ubintu's addition is essential. If users will wants that patch, they surely will file a request on bugzilla and it can always be added later..

George
Comment 5 Petteri Räty (RETIRED) gentoo-dev 2007-12-16 02:22:10 UTC
(In reply to comment #3)
> Created an attachment (id=116080) [edit]
> toshset-1.72.ebuild
> 

Why is pciutils only need at compile time?
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-06-08 16:44:56 UTC
Hello, everyone.

It seems that at least one ebuild related to this bug exists in the Sunrise overlay at the moment. However, I have to regretfully announce that after a long inactivity period the Sunrise project has been discontinued and the related overlay will be eventually removed. For this reason, I'd like to ask you to reevaluate the ebuilds and consider moving them. If you'd like to maintain a package from Sunrise in Gentoo, please take a look at our Proxy Maintainers [1] project.

Please make sure to take ebuilds from the unreviewed developer Sunrise repository [2] rather than the -reviewed one, since the latter has not been updated for over a year. While at it, please note that:

1. Adding a package to Gentoo requires declaring yourself as an active maintainer for it. All bugs regarding the package will be assigned to you, and you will be expected to maintain it.

2. Some packages may not be suitable for addition anymore. While there's no strong rules that would prevent you from adding a package, it may be a bad idea to add old-unmaintained packages that will shortly result in a large number of bugs reported with no solution. If that is the case, please close the bug as RESOLVED/OBSOLETE to make it easier to find packages worth adding.

3. Some of the bugs were already closed as WONTFIX/OBSOLETE/... while the relevant ebuild was kept in Sunrise. If you disagree with the original decision, you still can add the ebuild via proxy-maint.

4. Pleaes note that many of the Sunrise ebuilds are old and may be buggy. If you decide to move them, please make sure to update/clean them up. The proxy-maint team will also review your ebuilds, therefore making sure they land in Gentoo in good quality.

Once again, thank you for your contribution. We hope that you will still want to contribute to Gentoo, through proxy-maint or otherwise.


[1]:https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
[2]:https://gitweb.gentoo.org/proj/sunrise.git/