Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 111946 - distccmon-text output is unwieldy
Summary: distccmon-text output is unwieldy
Status: RESOLVED LATER
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Lisa Seelye (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-09 01:46 UTC by Eddie Parker
Modified: 2006-01-16 08:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (mon-text.c.patch,1.12 KB, patch)
2005-11-09 07:21 UTC, Eddie Parker
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eddie Parker 2005-11-09 01:46:28 UTC
I have a patch I'd like to submit that I put on all my builds for the
distccmon-text. It enables timestamping and only kicks out a newline if
something's changed.

The default behaviour has no timestamp ("When did this happen again??"), and the
newlines come every 'N' seconds (for whatever value of N you specify on the
command line), even if nothing's changed.

I'm not sure if this is worth putting in bugzilla, but I thought it's worth a
shot. :)

Reproducible: Always
Steps to Reproduce:
N/A
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2005-11-09 03:00:35 UTC
The patch seems to be missing... ;-)
Comment 2 Eddie Parker 2005-11-09 07:21:15 UTC
Created attachment 72494 [details, diff]
Patch

This patch adds a timestamp and doesn't update unless something's changed.
Comment 3 Eddie Parker 2005-11-09 07:21:56 UTC
Apologies on not submitting the patch - my machine was submitting rather slowly
so I went to bed. :) THe patch is there now. :)

Let me know what you think!
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2005-11-09 08:10:15 UTC
You forgot to reopen... 
Comment 5 Eddie Parker 2005-11-09 08:38:26 UTC
What can I say, I'm awesome at this bugzilla thing. :)

Sorry. Please don't let my incompetence in filing bugs impact this patch. I'd
really like it in the distcc build. It makes the monitor a lot more useful. :)
Comment 6 Lisa Seelye (RETIRED) gentoo-dev 2005-11-09 09:11:38 UTC
what version of the source was this made on?

have you sent it upstream to the distcc list? when you do please give the Gentoo 
bug number as a reference.

distcc@lists.samba.org

i will give this a try in an hour and see if it works as advertised. if it works 
i'll commit it.
Comment 7 Eddie Parker 2005-11-09 09:24:40 UTC
This is made off of the latest:
http://distcc.samba.org/ftp/distcc/distcc-2.18.3.tar.bz2

I originally sent a modified version of this patch to the distcc group about a
year ago but it wasn't integrated. Someone then cleaned it up, and it still
wasn't added. There was no reason given (I assume it was simply a lack of time,
or the changes weren't big enough, I'm not sure).

I'll e-mail the distcc list the patch as well as the bug reference number again,
in the hopes they'll integrate it.
Comment 8 Eddie Parker 2005-11-10 08:48:39 UTC
My thread on the distcc list.
Comment 9 Eddie Parker 2005-11-10 08:50:17 UTC
Err, I meant to attach a link with that:

http://lists.samba.org/archive/distcc/2005q4/003179.html
Comment 10 Lisa Seelye (RETIRED) gentoo-dev 2006-01-16 08:04:54 UTC
When this is implemented upstream I'll also make sure it's implemented here.  Unfortunately if I do this on Gentoo I'll have to do every other patch which isn't supported upstream.

Sorry.