Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 110443 - Repoman should complain when committing straight to stable
Summary: Repoman should complain when committing straight to stable
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 181949
  Show dependency tree
 
Reported: 2005-10-25 07:59 UTC by Petteri Räty (RETIRED)
Modified: 2007-09-09 13:50 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add a KEYWORDS.stable check and a --force option (stable_keywords.patch,3.01 KB, patch)
2007-08-27 22:55 UTC, Zac Medico
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2005-10-25 07:59:19 UTC
Now repoman actually makes it an error when all ebuilds are ~arch. Actually
repoman should check and complain if new ebuilds are committed straight to stable. 
This should be easy to implement as follows:
check cvs status --> new file --> check KEYWORDS --> something stable --> complain
Comment 1 solar (RETIRED) gentoo-dev 2005-10-25 08:02:34 UTC
s/complain/fatal
Comment 2 John Mylchreest (RETIRED) gentoo-dev 2005-10-25 08:11:21 UTC
I can see some use of comitting straight to stable, but lets face it.. policy
says otherwise and fatal is good for me.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2005-10-25 08:24:04 UTC
(In reply to comment #2)
> I can see some use of comitting straight to stable, but lets face it.. policy
> says otherwise and fatal is good for me.

Why not just make two commits then? Of course I don't recommend this practise
either because it would be better that someone else than the maintainer took
care of the keywording. Two pairs of eyes are better.
Comment 4 solar (RETIRED) gentoo-dev 2005-11-04 12:33:06 UTC
There does 1 exist case when commiting right into stable seems to be 
semi normal. Thats when moving a stable package around via epkgmove.
Comment 5 SpanKY gentoo-dev 2005-11-04 12:41:39 UTC
should be easy to detect though, things like Manifest and ChangeLog
would not yet be committed so the CVS/ files would list them as [A]dded
Comment 6 Zac Medico gentoo-dev 2007-08-27 18:02:29 UTC
(In reply to comment #4)
> There does 1 exist case when commiting right into stable seems to be 
> semi normal. Thats when moving a stable package around via epkgmove.

Another case is when somebody accidentally removes a stable ebuild and breaks some dependency, then has to add it back again. I suppose we can just add a --force-commit option or something.
Comment 7 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-08-27 18:42:26 UTC
(In reply to comment #6)
> some dependency, then has to add it back again. I suppose we can just add a
> --force-commit option or something.
 
Could make all currently non-fatal warnings fail at default and this option would override them. (I can also imagine a yes/no dialogue but maybe it's safer to require re-run with this option, although I can imagine certain people, who also ignore ChangeLog's etc, to alias that option to be always used, can't be helped). Straight-to-stable could be then one of these warnings.
Comment 8 Zac Medico gentoo-dev 2007-08-27 22:55:04 UTC
Created attachment 129397 [details, diff]
add a KEYWORDS.stable check and a --force option

(In reply to comment #7)
> Could make all currently non-fatal warnings fail at default and this option
> would override them.

Maybe that's appropriate for some but I'm not sure about doing that for all of them until I run repoman on the full tree and see how common or uncommon they are.
Comment 9 Zac Medico gentoo-dev 2007-09-07 19:17:58 UTC
This has been released in 2.1.3.8. The --force option will skip the most time consuming QA checks and the commit message will indicate when this option has been used.