Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 108157 - rox.eclass enhancements and fixups
Summary: rox.eclass enhancements and fixups
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Sergey Kuleshov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-05 01:49 UTC by Peter Hyman
Modified: 2005-12-09 13:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
rox.eclass (rox.eclass,3.42 KB, text/plain)
2005-10-05 01:50 UTC, Peter Hyman
Details
rox.eclass.patch (rox.eclass.patch,3.31 KB, patch)
2005-10-05 01:51 UTC, Peter Hyman
Details | Diff
rox.eclass (rox.eclass,3.72 KB, text/plain)
2005-10-31 05:43 UTC, Peter Hyman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Hyman 2005-10-05 01:49:43 UTC
Cleaned up code so all $variables have {} around them, eg ${variables}
throughout eclass. 
Added credit. 
Added code to automatically set the SET_PERM flag if an Application's src/
directory exists. This will save users the trouble of having to remember to add
SET_PERM=true when creating ebuilds and prevent errors that keep programs from
running since the executable won't be marked 0755 without it! 
Also, cleaned up language at the end in pkg_postinst.

Both full file and patch against current version are attached
Comment 1 Peter Hyman 2005-10-05 01:50:23 UTC
Created attachment 69901 [details]
rox.eclass

Updated rox.eclass file
Comment 2 Peter Hyman 2005-10-05 01:51:02 UTC
Created attachment 69902 [details, diff]
rox.eclass.patch

Patch against current rox.eclass that is in portage.
Comment 3 Peter Hyman 2005-10-31 05:43:44 UTC
Created attachment 71796 [details]
rox.eclass

many new fixes. Removes SET_PERM requirement for ebuilds since it is set
internally in the eclass. Adds a new KEEP_SRC variable which when set, will
preserve the src directory since sometimes users like to keep it :). Currently,
it is removed in rox_src_compile by default. In addition, all variable
references have been corrected to be in the ${VARIABLE} format. Extra quotes
that appeared in if [ ... ] statements to bracket the variables have been
removed to avoid unnecessary clutter. Thus, if [ -n "$ROX_CLIB_VER" ] is now if
[ -n ${ROX_CLIB_VER} ]. This is consistent with gentoo specs.
Comment 4 Sergey Kuleshov (RETIRED) gentoo-dev 2005-12-09 13:10:24 UTC
Thank you for great job!