Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 106487 - sys-apps/eject-2.0.13-r2 toggle patch problems
Summary: sys-apps/eject-2.0.13-r2 toggle patch problems
Status: RESOLVED DUPLICATE of bug 122256
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-18 23:29 UTC by Stuart W. Finlayson
Modified: 2006-02-09 20:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
eject-2.0.13-toggle-fix.patch (eject-2.0.13-toggle-fix.patch,1.36 KB, patch)
2005-09-18 23:30 UTC, Stuart W. Finlayson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart W. Finlayson 2005-09-18 23:29:02 UTC
This relates to the patch that was added for bug #62612, which adds MacOSX   
style of ejecting/loading the cd-rom tray through the use of an option -T.     
   
I think I found three problems with this patch.  First, the "exit(0);" in the   
section that handles the -T option is misplaced.  Allowing options that appear 
after the -T option to be processed.  Second, the EjectCdrom() is not checked 
for errors.  I found this by mounting the device and running `eject -T -v`, 
which lead to me seeing the third problem.  Third, the section that handles 
the -T option is misplaced.  It should occur after the device(s) is/are 
unmounted, otherwise it will not eject.
Comment 1 Stuart W. Finlayson 2005-09-18 23:30:43 UTC
Created attachment 68792 [details, diff]
eject-2.0.13-toggle-fix.patch

Fixes problems with earlier patch.
Comment 2 SpanKY gentoo-dev 2006-02-09 20:55:07 UTC

*** This bug has been marked as a duplicate of 122256 ***