Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 104384 - net-mail/fetchmail-6.2.5.2 does not really respect USE="-nls"
Summary: net-mail/fetchmail-6.2.5.2 does not really respect USE="-nls"
Status: VERIFIED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-31 07:49 UTC by Natanael Copa
Modified: 2005-12-16 02:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fetchmail-6.2.5.2-nonls.patch (fetchmail-6.2.5.2-nonls.patch,1.61 KB, patch)
2005-08-31 07:57 UTC, Natanael Copa
Details | Diff
fetchmail-6.2.5.2-nonls.patch (fetchmail-6.2.5.2-nonls.patch,2.18 KB, patch)
2005-08-31 09:01 UTC, Natanael Copa
Details | Diff
fetchmail-6.2.5.2.ebuild.patch (fetchmail-6.2.5.2.ebuild.patch,573 bytes, patch)
2005-08-31 09:03 UTC, Natanael Copa
Details | Diff
fetchmail-6.2.5.2.ebuild.patch (update) (fetchmail-6.2.5.2.ebuild.patch,832 bytes, patch)
2005-10-08 08:44 UTC, Natanael Copa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2005-08-31 07:49:44 UTC
Even if -nls is set in USE, fetchmail requires libiconv and gettext (its in the
DEPEND).

Reproducible: Always
Steps to Reproduce:
1. USE=-nls
2.
3.

Actual Results:  
fetchmail gets compiled with localization.

Expected Results:  
fetchmail should be compiled without localization.

libiconv and gettext creates problems in embedded.
Comment 1 Natanael Copa 2005-08-31 07:57:11 UTC
Created attachment 67344 [details, diff]
fetchmail-6.2.5.2-nonls.patch

This patch should be applied when USE=-nls.
sys-devel/gettext should *only* be in RDEPEND when USE=nls
Comment 2 Natanael Copa 2005-08-31 09:01:21 UTC
Created attachment 67347 [details, diff]
fetchmail-6.2.5.2-nonls.patch

This patch also strips some lines in the install section in Makefile.in that I
forgot in the previous.
Comment 3 Natanael Copa 2005-08-31 09:03:41 UTC
Created attachment 67348 [details, diff]
fetchmail-6.2.5.2.ebuild.patch

Patch for the ebuild to apply the previously posted nonls patch.
Comment 4 Natanael Copa 2005-10-08 08:40:21 UTC
Sorry for making noise, but...

I just fixed this thing once again and were just about to submit a new, very
similar patch when I found out that I already had submitted one.

While I were there, I noticed that the entire thing is trigged by the kerberos
patch who modifies configure.in. That makes make execute autoconf and autoconf
needs the AM_GNU_GETTEXT which fails on embedded (uclibc) systems.

So, I suggest this should happen:

if kerberos is turned on:
    apply kerberos path
    if nls is disabled: apply the nonls-patch
otherwise... just ingnore those patches.

That way will neither the kerberos patch or nonls patch be applied if kerberos
is turned off and autoconf will not be executed. That will dramatically reduce
build time for all non-kerberos users and it will work without the nonsl patch
on embedded.

Comment 5 Natanael Copa 2005-10-08 08:44:10 UTC
Created attachment 70159 [details, diff]
fetchmail-6.2.5.2.ebuild.patch (update)

It would be nice if this could be commited. (so I won't forget it and fix it a
third time)
Comment 6 Andrej Kacian (RETIRED) gentoo-dev 2005-12-10 04:43:04 UTC
This should be OK in freshly added fetchmail-6.3.0 - it builds fine with
USE=-nls, and it doesn't install .po files into system.

Please test and comment here. Thank you.
Comment 7 Natanael Copa 2005-12-16 02:02:04 UTC
Works like a charm.

Thanks!
Comment 8 Andrej Kacian (RETIRED) gentoo-dev 2005-12-16 02:15:38 UTC
I'm glad. Closing bug.