Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 103383 - sgml-catalog eclass uses GNU-specific seq command
Summary: sgml-catalog eclass uses GNU-specific seq command
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Text-Markup Team (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 103124
  Show dependency tree
 
Reported: 2005-08-22 15:27 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sgml-catalog-eclass.patch (sgml-catalog-eclass.patch,874 bytes, patch)
2005-08-22 15:27 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-08-22 15:27:03 UTC
As per summary, sgml-catalog eclass doesn't work on Gentoo/FreeBSD (and maybe 
on OSX/Darwin, too), as seq command is missing in base system. 
 
The attached patch makes it behave correctly using internal bash {} expansion. 
The solution is a bit tricky, the alternative is to use a full-size for with 
arithmetic expansion. 
 
Thanks, 
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-08-22 15:27:25 UTC
Created attachment 66587 [details, diff]
sgml-catalog-eclass.patch
Comment 2 Fabian Groffen gentoo-dev 2005-08-22 22:29:11 UTC
Some additional info:
when installing coreutils-darwin `seq` is available on OSX.  Isn't it more
convenient to require that coreutils are installed?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-08-23 00:36:17 UTC
For a single 'seq' command, used in a single eclass, I'd rather *not* install 
the full coreutils on FreeBSD, as it's not at all a "little" package. 
sgml-catalog ebuilds are installed by gnome, and it has already enough silly 
dependencies without adding coreutils to them. 
 
Comment 4 Fabian Groffen gentoo-dev 2005-08-23 08:55:44 UTC
after giving it a second thought, doing it in bash with internal bash routines
sounds good anyway, since it avoids an expensive fork + some context switches.
Comment 5 Leonardo Boshell (RETIRED) gentoo-dev 2005-09-08 10:39:13 UTC
Fixed in CVS. Sorry for the delay :).