Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 101543 - mplayerplug-in 64bit fix.
Summary: mplayerplug-in 64bit fix.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Joe Jezak (RETIRED)
URL:
Whiteboard:
Keywords: Inclusion
Depends on: 100809
Blocks:
  Show dependency tree
 
Reported: 2005-08-06 06:02 UTC by Ian Kumlien
Modified: 2005-09-29 00:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
a patch to fix the pronbelm (mplayerplugin.diff,929 bytes, patch)
2005-08-06 06:02 UTC, Ian Kumlien
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Kumlien 2005-08-06 06:02:08 UTC
Source/plugin.cpp: In member function 'virtual NPError
nsPluginInstance::SetWindow(NPWindow*)':
Source/plugin.cpp:593: error: cast from 'void*' to 'unsigned int' loses precision
Source/plugin.cpp:618: error: cast from 'void*' to 'unsigned int' loses precision
make: *** [plugin.o] Error 1
make: *** Waiting for unfinished jobs....

Due to %x formatting they cast pointers to (unsigned int), lets change this to
%lx and (unsigned long). It should works just the same on 32 bit, lemme know if
it doesn't.

(I'll attach a patch)

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Ian Kumlien 2005-08-06 06:02:54 UTC
Created attachment 65228 [details, diff]
a patch to fix the pronbelm
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-08-06 06:09:47 UTC
I think %p is probably the best bet to be safe for the future. 
 
Comment 3 Kevin DeKorte 2005-08-06 06:35:20 UTC
mplayerplug-in v3.05 has a similar patch included in the code.
Comment 4 Joe Jezak (RETIRED) gentoo-dev 2005-09-25 18:37:42 UTC
Fixed in >=3.05, so depends on bug 100809.
Comment 5 Joe Jezak (RETIRED) gentoo-dev 2005-09-29 00:11:31 UTC
3.11 is in portage, so this should be fixed now.