Bug 99882 – beep-media-player-0.9.7-r6 can't read UTF16

• Product: Gentoo Linux
• Status: RESOLVED WONTFIX

[Description Steve M. Kim 2005-07-22 02:22:34 UTC]

I have a bunch of MP3s which were created using iTunes in Windows. The MP3s have
ID3v2 tags encoded in utf-16. bmp installed from the latest package (0.9.7-r6)
does not read utf16.

This issue has come up on the beep-media-player Bugzilla
(http://www.sosdg.org/~larne/bugs/show_bug.cgi?id=101), and patches have been
offered. (Newbie question: How would I test a patch? Can I just create an
appropriate beep-media-player-my-custom.ebuild and throw the patch file into
/usr/portage/media-sound/beep-media-player/files?) Maybe the next portage
release can have a working ID3 tag unicode patch included?

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Steve M. Kim 2005-07-22 02:24:43 UTC]

Created attachment 64042 [details, diff]
a patch posted on the b-m-p bugzilla, http://www.sosdg.org/~larne/bugs/show_bug.cgi?id=101

I have no idea whether this works. Credit should go to the folks at the
beep-media-player bugzilla.

[Comment 2 Tony Vroon (RETIRED) 2005-07-22 13:19:15 UTC]

I can test this for you. Upload a non-copyrighted sample file which exhibits the
problem. It can be very short; an audio recording of a beep or your workstation
booting up for all I care. However, I need a testcase to see if this actually
does something :)
I have no problem merging this patch into an -r7 just before 0.9.7.1 is
released, as I have one more patch queued up (ipv6 support for streams).

[Comment 3 Steve M. Kim 2005-07-23 03:37:37 UTC]

Created attachment 64115 [details]
testcase mp3 with id3v2 tag encoded in utf16

When I load this mp3 into beep-media-player, the scrolling title looks like

*** 1.Foo-|0|?@?? (invalid UTF-8) (1:45)

where '|0|' is one of those non-displaying character placeholders.

[Comment 4 Steve M. Kim 2005-07-23 03:45:48 UTC]

I should point out that this failure does not occur for all UTF-16 encoded tags;
it depends on the types of characters that are included in the string. Also,
padding the beginning of a string with ASCII-set characters may sometimes allow
UTF-16 encoded tags to "pass" as valid UTF-8 when otherwise they would be
rejected by beep-media-player.

[Comment 5 Tony Vroon (RETIRED) 2005-07-23 17:23:06 UTC]

The patch changes the title display for me; instead of a row of incomprehesible
characters, a longer row of unreadable characters sits lower on the line so I
can't read them. The following warning is emitted:

(beep-media-player:12078): Pango-WARNING **: Invalid UTF-8 string passed to
pango_layout_set_text()

[Comment 6 Tony Vroon (RETIRED) 2005-07-23 17:30:47 UTC]

Giving this one the benefit of the doubt, it does not break playback, and my
ID3v1 & ID3v2 tags are still displayed properly.

[Comment 7 Tony Vroon (RETIRED) 2005-07-29 17:43:04 UTC]

Bug #100560 shows that I should not have accepted this patch, it causes
problems. Pulling -r7 release and defective patch from the portage tree. 

[Comment 8 Tony Vroon (RETIRED) 2005-07-29 17:43:26 UTC]

Provide a working patch and clear testcase if you want this merged, please.