Bug 99512

Summary:	mozilla-launcher-1.35 fails to start mozilla-firefox-bin or mozilla-thunderbird-bin when called without -bin
Product:	Gentoo Linux	Reporter:	Martin von Gagern <Martin.vGagern>
Component:	Current packages	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	High
Version:	2005.0
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	mozilla-launcher.diff

Description Martin von Gagern 2005-07-19 04:52:39 UTC

Just calling "firefox" or "thunderbird" when only mozilla-firefox-bin resp.
mozilla-thunderbird-bin is installed fails. This is because MOZILLA_FIVE_HOME is
set for the source package and not changed for the binary package.


Reproducible: Always
Steps to Reproduce:
1. emerge only mozilla-firefox-bin, not mozilla-firefox
2. emerge =www-client/mozilla-launcher-1.35
3. firefox

Actual Results:  
firefox: can't find the browser :-(

Expected Results:  
mozilla-firefox-bin started

I will attach a patch to solve this

Comment 1 Martin von Gagern 2005-07-19 04:54:28 UTC

Created attachment 63770 [details, diff]
mozilla-launcher.diff

This patch solves the issue by always setting MOZILLA_FIVE_HOME - either based
on MOZILLA_LIBDIR or as default path.

Comment 2 Jory A. Pratt 2005-07-19 08:37:14 UTC

what version of -bins do you have installed?

Comment 3 Martin von Gagern 2005-07-19 09:00:15 UTC

I have only www-client/mozilla-firefox-bin-1.0.5, my thunderbird is from source.

Looking at the ebuild, I see that mozilla-firefox-bin-1.0.5-r1 should be able to
solve this issue. I noted the following lines in the ebuild:
        # Create /usr/bin/firefox
        install_mozilla_launcher_stub firefox-bin /opt/firefox
which in fact only create /usr/bin/firefox-bin, the symlink from
/usr/bin/firefox to firefox-bin is as far as I can see only added in
update_mozilla_launcher_symlinks, which gets called in pkg_postinst.
But this is only a very minor issue I just noted.

Anyway, on the one hand this whole bug should not be a problem for recent bins,
but on the other hand the script is designed to cope with old packages as well,
so it either should do this properly, or drop this backward compatibility
completely and just get some additional dependencies to disallow older bin packages.

I'm all for applying this patch and keep mozilla-launcher backwards compatible.

Comment 4 Jory A. Pratt 2005-07-19 09:16:32 UTC

Problem with patch is it prevents agriffis from contining forward with the way
he is wanting to move with mozilla-launcher I will talk with him later today and
address the symlink issue from firefox-bin to firefox and visa-versa with
thunderbird-bin to thunderbird.

Comment 5 Aron Griffis (RETIRED) gentoo-dev

2005-07-19 09:47:28 UTC

Actually, the patch is great.  Thanks Martin!

I've applied the patch in mozilla-launcher-1.37.  Please re-open this bug if the
problem persists after updating.