| Summary: | firefox: cherry picking on Fedora patches | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | TGL <tom.gl> |
| Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://cvs.fedora.redhat.com/viewcvs/rpms/firefox/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
01_firefox-1.0.5-fedora--minor_fixes.patch
02_firefox-1.0.5-fedora--better_desktop_entry.patch 03_firefox-1.0.5-fedora--better_gnome_integration.patch 04_firefox-1.0.5-fedora--pango.patch 01_firefox-1.0.5-fedora--minor_fixes.patch 04_firefox-1.0.5-fedora--pango.patch 01_firefox-1.0.6-r1-fedora--minor_fixes.patch 03_firefox-1.0.6-r1-fedora--better_gnome_integration.patch 04_firefox-1.0.6-r1-fedora--pango.patch 01_firefox-1.0.6-r3-fedora--minor_fixes.patch 03_firefox-1.0.6-r3-fedora--better_gnome_integration.patch 04_firefox-1.0.6-r3-fedora--pango.patch |
||
Created attachment 63429 [details, diff]
01_firefox-1.0.5-fedora--minor_fixes.patch
Created attachment 63430 [details, diff]
02_firefox-1.0.5-fedora--better_desktop_entry.patch
Created attachment 63431 [details, diff]
03_firefox-1.0.5-fedora--better_gnome_integration.patch
Created attachment 63432 [details, diff]
04_firefox-1.0.5-fedora--pango.patch
Created attachment 63433 [details, diff]
01_firefox-1.0.5-fedora--minor_fixes.patch
Err... one chunk was in the wrong patch.
Created attachment 63434 [details, diff]
04_firefox-1.0.5-fedora--pango.patch
I will submit some new ebuild patches (#01, #03 and #04) rediffed for 1.0.6-r1. The desktop entry patch (#02) is still valid. About the Pango patches, I've found some test cases where it actually improves rendering: - without Pango: http://tdegreni.free.fr/temp/firefox-tibetain-nopango.png - with Pango: http://tdegreni.free.fr/temp/firefox-tibetain-pango.png The text is in Tibetan, using a font from http://iris.lib.virginia.edu/tibet/xml/show.php?xml=/tools/tibfonts.xml&l=uva10928423419921 According to someone who can read Tibetan, only the Pango-enabled rendering is correct (without Pango, some symbols overlaps horizontaly, and there are some wrong vertical whitespaces too). I've been told that the same happens with any Brahmi language, like Indian, Thai, Kmer, etc. Created attachment 64063 [details, diff]
01_firefox-1.0.6-r1-fedora--minor_fixes.patch
Created attachment 64064 [details, diff]
03_firefox-1.0.6-r1-fedora--better_gnome_integration.patch
Created attachment 64065 [details, diff]
04_firefox-1.0.6-r1-fedora--pango.patch
Created attachment 64196 [details, diff]
01_firefox-1.0.6-r3-fedora--minor_fixes.patch
Created attachment 64197 [details, diff]
03_firefox-1.0.6-r3-fedora--better_gnome_integration.patch
Created attachment 64198 [details, diff]
04_firefox-1.0.6-r3-fedora--pango.patch
All patches i had selected are now in firefox-1.0.7-r2 (mozilla-1.7.12-patches-1.0.tar.bz2), so i will close this bug. Many thanks Az'. The only remaining part is the .desktop stuffs (MIME types associations), but i will re-submit that as a new bug since it was not the main point of this one. Ugh, sorry, missed this bug. |
I've tried various patches from the Fedora firefox package, and there are several interesting stuffs there. I will attach a serie of patches against the current 1.0.5 ebuild with some of them: 01_firefox-1.0.5-fedora--minor_fixes.patch and 02_firefox-1.0.5-fedora--better_desktop_entry.patch are some minor non-optionnal fixes, addition of a manpage, and improvement to the .desktop file (adds MIME handling declaration, so that Firefox is listed by Nautilus and others as an application to open HTML files). 03_firefox-1.0.5-fedora--better_gnome_integration.patch apply patches only if USE=gnome. They enable the GTK+ file selector, and other minor stuffs like URI handling by Gnome helper application ("man:foo" opens yelp, etc). Finally, 04_firefox-1.0.5-fedora--pango.patch applies a set of patches for Pango rendering of text if USE=pango. It works, but i can't say i've seen any difference, so i only attach that one for information. Maybe some people who can read right-to-left written languages could test it and tell if it enhances anything for them... Note that this report is somehow related to bug #89242 (Ubuntu patches, but it's too big imho) and bug #75404 (pango support too, but Fedora has additional fixes).