Bug 96461 – gpdf-2.10.0 does not build on newer gcc-4.0.1_pre releases

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Walter Meinl 2005-06-18 06:34:42 UTC]

Rebuilding my system with gcc-4.0.1_pre20050607 (and now with 20050616) after a harddrive change I was not able to emerge gpdf-2.10.0, though it compiled recently with gcc-4.0.1_beta20050514 and there is already a gcc4 patch in the tree. I attached the error message.
Compile stopped during the xpdf-part having problems with TextOutputDev.h and .cc. This reminded me that a few weeks ago there was the same problem building xpdf-3.00. In the meantime xpdf-3.00 has its gcc-41.patch and compiles flawlessly. The solution for a successful build of gpdf-2.10.0 with newer gcc-4.0.1-versions is obviously to apply the second part of the xpdf-patch also to gpdf. I attached a merged patch of the original gpdf-2.10.0-amd64-gcc4.patch with the respective part of the xpdf-patch. It can be applied also separately.

Concerning the original patch in the tree, I made the observation that the  patch in the gentoo tree differs slighly from that proposed by debian-devs (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=286889). The latter patches the  the same file and the same position, but there is an additional line (212) changed:

diff -urN ../tmp-orig/gpdf-2.8.0/xpdf/gpdf-control.cc ./xpdf/gpdf-control.cc
--- ../tmp-orig/gpdf-2.8.0/xpdf/gpdf-control.cc	2004-09-13 18:54:51.000000000 +0200
+++ ./xpdf/gpdf-control.cc	2004-12-22 21:20:18.340107456 +0100
@@ -209,12 +209,12 @@
 			   const gchar * status)
 {
 	GPdfControlPrivate *priv;
-	guint to_id;
+	unsigned long to_id;
 
 	g_return_if_fail (GPDF_IS_NON_NULL_CONTROL (control));
 	priv = control->priv;
 
-	if ((to_id = (unsigned int)
+	if ((to_id = (unsigned long)
 	     g_object_get_data (G_OBJECT (control),
 				"status-timeout-id")) != 0) {
 		g_object_set_data (G_OBJECT (control),

while the gentoo-patch only changes the "if" statement. As the debian patch would also apply, I wonder which patch would be better or the correct one.

[Comment 1 Walter Meinl 2005-06-18 06:36:15 UTC]

Created attachment 61442 [details]
stop output

here is the error output

[Comment 2 Walter Meinl 2005-06-18 06:38:42 UTC]

Created attachment 61443 [details, diff]
the merged patch including the xpdf patch

here is the combined patch including the second part of the
xpdf-3.00-gcc41.patch

[Comment 3 Martin Schlemmer (RETIRED) 2005-06-18 07:08:07 UTC]

I'm thinking the debian one might be the better one ...  Anyhow, updated the
patch, thanks.