Summary: | Freecraft SDLCD address space leak | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | qube99 |
Component: | [OLD] Games | Assignee: | Gentoo Games <games> |
Status: | RESOLVED UPSTREAM | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Makes freecraft use one sdl thread for SDLCD CDRomCheck
Update patch. The address leak is due to not calling SDL_WaitThread. This resolves this while using the new signalling mechanism. |
Description
qube99
2005-06-17 12:46:18 UTC
Created attachment 61409 [details, diff]
Makes freecraft use one sdl thread for SDLCD CDRomCheck
Created attachment 61886 [details, diff]
Update patch. The address leak is due to not calling SDL_WaitThread. This resolves this while using the new signalling mechanism.
no, the saner fix would be to: - have a global var 'cdrom_check_thread' and init it to NULL - before creating the new thread, if 'cdrom_check_thread' is not NULL, then call SDL_KillThread(cdrom_check_thread) - create new thread: cdrom_check_thread = SDL_CreateThread(CDRomCheck, NULL); |