Bug 96334

Summary:	flexbackup incorrectly determines bash 3.x to be bash 1.x
Product:	Gentoo Linux	Reporter:	Mark Keisler <grimm26>
Component:	Current packages	Assignee:	App-Backup Team <app-backup>
Status:	RESOLVED FIXED
Severity:	major	CC:	max, mholzer, tschenturs
Priority:	High	Keywords:	Inclusion
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://members.cox.net/mkeisler/flexbackup_error.txt
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	patch for this bug Fixes detection of bash3 as bash1

Description Mark Keisler 2005-06-16 20:22:51 UTC

flexbackup does a test to find out if /bin/sh is really another shell
masquerading as bourne shell.  The logic for checking bash assumes that if it is
not 2.x, it must be 1.  With bash 3.x in place, flexbackup breaks by assuming it
is bash 1.

Reproducible: Always
Steps to Reproduce:
1. hvae /bin/ash be a link to bash
2. run flexbackup

Actual Results:  
It errored out.  See http://members.cox.net/mkeisler/flexbackup_error.txt

Expected Results:  
done s successful backup.

I have bash3 installed.
This patch will fix it.
5399c5399
<               if ($ver =~ m/^2/) {
---
>               if ($ver =~ m/^2|^3/) {

Comment 1 Mark Keisler 2005-06-16 20:26:18 UTC

Created attachment 61367 [details, diff]
patch for this bug

fixes bash3 being identified as bash1

Comment 2 Mark Keisler 2005-06-16 22:30:18 UTC

Created attachment 61369 [details, diff]
Fixes detection of bash3 as bash1

This is a better patch since it will work with any future bash release number. 
Dont' know why it wans't this way in the first place.  Maybe some bash versions
pre 2.x do not have a $BASH_VERSION variable?

Comment 3 Jakub Moc (RETIRED) gentoo-dev

2005-12-05 12:31:14 UTC

Mass reassign wrt Bug 23718, maintainer being retired.

Comment 4 Lisa Seelye (RETIRED) gentoo-dev

2006-05-25 15:32:33 UTC

Does this fail for all versions of flexbackup?

Comment 5 Mark Keisler 2006-05-25 15:46:15 UTC

I think this fix may have been slipped into 1.2.1-r1 because it has the code from my patch in it.  I don't see a note in the changelog about it, though.  May as well close this bug then.