Bug 95591 – command_names = 1 in lvm.conf causes /lib/rcscripts/addons/lvm-stop.sh to fail

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Milan Holzäpfel 2005-06-09 11:35:10 UTC]

Hello,

if the option command_names of the log section in /etc/lvm/lvm.conf is set to 1, 
/lib/rcscripts/addons/lvm-stop.sh fails to parse the output correctly, as it is 
not expexting the additional column. 

Example: With command_names = 0:
bombax:~ # lvdisplay /dev/lvm/primary/go0-usr | grep 'LV Name'
  LV Name                /dev/lvm/primary/go0-usr

With command_names = 1:
bombax:~ # lvdisplay /dev/lvm/primary/go0-usr | grep 'LV Name'
lvdisplay  LV Name                /dev/lvm/primary/go0-usr


Reproducible: Always
Steps to Reproduce:
1. set command_names = 1 in section log of lvm.conf
2. shutdown the system using baselayout-1.11.12-r4's lvm addon
3.

Actual Results:  
The output is not parsed properly, wrong parameters are given to subsequent lvm 
commands. 

Expected Results:  
The script should take this setting into account, I'm not sure about the best 
way to do this? Parse "lvm dumpconfig", do some additional awk, ...?

Portage 2.0.51.19 (default-linux/amd64/2005.0, gcc-3.4.3, glibc-2.3.4.20041102-
r1, 2.6.11.11-grsec-18 x86_64)
=================================================================
System uname: 2.6.11.11-grsec-18 x86_64 AMD Athlon(tm) 64 Processor 3000+
Gentoo Base System version 1.6.12
Python:              dev-lang/python-2.3.4-r1,dev-lang/python-2.4.1 [2.4.1 (#1, 
Apr 28 2005, 20:44:47)]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.4-r1, 2.4.1
sys-apps/sandbox:    [Not Present]
sys-devel/autoconf:  2.13, 2.59-r6
sys-devel/automake:  1.4_p6, 1.7.9-r1, 1.8.5-r3, 1.6.3, 1.5, 1.9.5
sys-devel/binutils:  2.15.92.0.2-r10
sys-devel/libtool:   1.5.16
virtual/os-headers:  2.6.8.1-r4
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CFLAGS="-Os -march=k8 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /lib/rcscripts/addons /usr/kde/2/share/config /usr/kde/3.4/
env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config /
usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/
texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/
platex/config/ /usr/share/texmf/xdvi/ /var/qmail/alias /var/qmail/control /var/
vpopmail/domains /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-Os -march=k8 -pipe -fomit-frame-pointer"
DISTDIR="/usr/src/pkg"
FEATURES="autoaddcvs autoconfig buildpkg ccache distlocks sandbox sfperms strict 
userpriv usersandbox"
GENTOO_MIRRORS="ftp://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo ftp://ftp.
uni-erlangen.de/pub/mirrors/gentoo http://ftp.uni-erlangen.de/pub/mirrors/gentoo 
ftp://gentoo.inode.at/source http://gentoo.inode.at/"
LANG="de_DE.UTF-8"
LC_ALL="de_DE.UTF-8"
LINGUAS="de en_GB"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/pkg"
PORTAGE_TMPDIR="/usr/portage/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="amd64 3dnowex X aalib acpi acpi4linux alsa apache2 audiofile avi bash-
completion bcmath bdf berkdb bitmap-fonts bzip2 bzlib cdparanoia cdr crypt cups 
curl dga dlloader dvd dvdread encode exif fam ffmpeg flac font-server foomaticdb 
fortran freetds freetype fs ftp gd gdbm gif gimp gimpprint glut gmp gnutls 
gphoto2 gpm gstreamer gtk gtk2 gtkhtml iconv imagemagick imap imlib innodb ipv6 
jabber jack java jp2 jpeg kerberos ldap lesstif libcaca libwww lzo lzw lzw-tiff 
mad mailwrapper matroska mbox mcal memlimit mmap mng mp3 mysql ncurses nls 
nvidia ogg oggvorbis openal opengl pam perl php png ppds python qt readline sasl 
scanner sdl snmp speex spell sql ssl subversion svg tcltk tcpd tetex theora tidy 
tiff truetype truetype-fonts type1-fonts unicode usb userlocales utf8 vidix 
visualization vorbis vpopmail wmf xanim xine xinerama xml xml2 xmms xpm xrandr 
xsl xv xvid xvmc zlib linguas_de linguas_en_GB userland_GNU kernel_linux 
elibc_glibc"
Unset:  ASFLAGS, CBUILD, CTARGET, LDFLAGS

[Comment 1 Eric Edgar (RETIRED) 2005-06-13 09:22:25 UTC]

I have a patch for this.  Just need to test it now before I release it.  
basically just replacing the awks with a sed regular expression takes care of 
the issue as far as I can tell.

[Comment 2 Eric Edgar (RETIRED) 2005-06-27 08:58:57 UTC]

reemerge lvm2 and let me know if that takes care of your issue.

[Comment 3 Eric Edgar (RETIRED) 2005-07-06 06:20:59 UTC]

In Portage