Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 954771

Summary: app-text/sword-1.9.0-r2 fails tests
Product: Gentoo Linux Reporter: Jonathan Lovelace <kingjon3377>
Component: Current packagesAssignee: Nicolas PARLANT <nicolas.parlant>
Status: RESOLVED FIXED    
Severity: normal CC: kingjon3377, nicolas.parlant, proxy-maint
Priority: Normal Keywords: PullRequest, TESTFAILURE
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/41807
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: app-text:sword-1.9.0-r2:20250427-011613.log
LastTest.log
emerge-info.txt

Description Jonathan Lovelace 2025-04-27 02:13:27 UTC
Created attachment 926233 [details]
app-text:sword-1.9.0-r2:20250427-011613.log

=app-text/sword-1.9.0-r2 fails its test phase for me, specifically the test sword_cppcheck_test, which gives the following output (from LastTest.log, omitting the long line giving the exact command it's running):

Directory: /var/tmp/portage/app-text/sword-1.9.0-r2/work/sword-1.9.0_build
"sword_cppcheck_test" start time: Apr 26 21:17 EDT
Output:
----------------------------------------------------------
cppcheck: error: unrecognized command line option: "--template".
<end of output>
Test time =   0.02 sec
----------------------------------------------------------
Test Fail Reason:
Error regular expression found in output. Regex=[ error: ]
"sword_cppcheck_test" end time: Apr 26 21:17 EDT
"sword_cppcheck_test" time elapsed: 00:00:00
----------------------------------------------------------
Comment 1 Jonathan Lovelace 2025-04-27 02:14:02 UTC
Created attachment 926234 [details]
LastTest.log
Comment 2 Jonathan Lovelace 2025-04-27 02:14:32 UTC
Created attachment 926235 [details]
emerge-info.txt
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-04-27 22:56:08 UTC
While this might mean we need to update our cppcheck, it's better to skip such linting tests for our purposes.
Comment 4 Nicolas PARLANT 2025-04-28 02:49:58 UTC
I didn't get this useless test/dep ...

In cmake/Findcppcheck.cmake :
"--template gcc" should be "--template=gcc"

I have two solutions :
- add this as a patch
- skip it with -DCMAKE_DISABLE_FIND_PACKAGE_cppcheck="True"

What's best to avoid revbump ?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-04-28 02:51:06 UTC
(In reply to Nicolas PARLANT from comment #4)
> - skip it with -DCMAKE_DISABLE_FIND_PACKAGE_cppcheck="True"

Let's do this, but ON instead of "True".
Comment 6 Larry the Git Cow gentoo-dev 2025-04-28 04:28:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d05c150976fc55d2d1dc70e3d2e068028a553e1

commit 5d05c150976fc55d2d1dc70e3d2e068028a553e1
Author:     Nicolas PARLANT <nicolas.parlant@parhuet.fr>
AuthorDate: 2025-04-28 02:59:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-04-28 04:27:37 +0000

    app-text/sword: skip cppcheck tests
    
    cppcheck fails to run :
    arg "--template gcc" should be "--template=gcc" in cmake/Findcppcheck.cmake
    
    But we don't really want such tests, so let's skip it.
    
    Closes: https://bugs.gentoo.org/954771
    Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
    Part-of: https://github.com/gentoo/gentoo/pull/41807
    Closes: https://github.com/gentoo/gentoo/pull/41807
    Signed-off-by: Sam James <sam@gentoo.org>

 app-text/sword/sword-1.9.0-r2.ebuild | 2 ++
 1 file changed, 2 insertions(+)