| Summary: | app-admin/eselect-1.4.29: rc-config show broken: /usr/share/eselect/modules/rc.eselect: line 71: service_stopping: command not found | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | sphakka <marcoep> |
| Component: | Current packages | Assignee: | Gentoo eselect Team <eselect> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | floppym, marcoep, navi, openrc |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | AMD64 | ||
| OS: | Linux | ||
| URL: | https://www.reddit.com/r/Gentoo/comments/1jc3ahe/eselect_rc_error/ | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=645240 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | Patch for rc.eselect | ||
|
Description
sphakka
2025-03-17 15:58:50 UTC
I have to wonder why this eselect module even exists. People should just use OpenRC commands directly. (In reply to Mike Gilbert from comment #1) > I have to wonder why this eselect module even exists. People should just use > OpenRC commands directly. Sure, but: # ls -l $(which rc-config) lrwxrwxrwx 1 root root 7 Mar 9 21:23 /usr/bin/rc-config -> eselect (In reply to sphakka from comment #2) My point stands: I don't understand why rc-config/rc.eselect exists. The functionality is already provided by the rc-status, rc-service, and rc-update commands provided by OpenRC. I would suggest dropping rc-config/rc.eselect from app-admin/eselect. Patches are welcome. When navi and I discussed this briefly, I think we agreed it should probably go. (In reply to Ulrich Müller from comment #4) > Patches are welcome. To elaborate on this, the rc.eselect module predates OpenRC, i.e. it already existed when I took over as eselect maintainer in 2009. I've done a minimum of maintenance to make the module work (see bug 180966, for example) and to keep it working with OpenRC. Going forward, I see three possible options: - The rc module gets a dedicated maintainer who is familiar with OpenRC internals. In this case, it should presumably be removed from eselect proper and moved to its own package. - We keep going with the bug-fixing mode that has worked (maybe just barely) for th e past years. I am happy to accept patches. - We drop the module altogether. I that case, I want to ask whether OpenRC itself provides all functionality of the module? > - We drop the module altogether. I that case, I want to ask whether OpenRC
> itself provides all functionality of the module?
out of the eselect rc actions:
add, delete, list -> rc-update
show -> rc-status
start, stop, reload, pause -> rc-service
the only thing to note is the api is different for rc-service:
`eselect rc <start|stop|restart|reload> $service`
is
`rc-service $service [command ...]`
meaning you can't start/stop/restart multiple services with one command, the other commands have pretty similar syntax to the eselect module
Created attachment 921591 [details, diff]
Patch for rc.eselect
@sphakka: Does attached patch fix the problem for you?
(In reply to Ulrich Müller from comment #8) > Created attachment 921591 [details, diff] [details, diff] > Patch for rc.eselect > > @sphakka: Does attached patch fix the problem for you? Yeah, it works, thanks! So I'll fix this bug, but also add a deprecation warning that rc-update, rc-service and rc-status should be used instead of rc.eselect. Then we can phase out the module after some transition time. (Unless there would be massive protests against removal, in which case I would reconsider but also ask the protesters to take over maintenance.) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/eselect.git/commit/?id=3bd8467f3b942e550d13efe7a98a230c7436d2a5 commit 3bd8467f3b942e550d13efe7a98a230c7436d2a5 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2025-03-22 05:39:51 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2025-03-22 05:39:51 +0000 Fix PATH in rc module * modules/rc.eselect (show_script_status): Add /usr/libexec/rc/bin to PATH. Display the correct status. Bug 951499. Bug: https://bugs.gentoo.org/951499 Signed-off-by: Ulrich Müller <ulm@gentoo.org> ChangeLog | 5 +++++ modules/rc.eselect | 11 ++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1965f2c3022ad7d7a82d73f0c2817f41deff161 commit c1965f2c3022ad7d7a82d73f0c2817f41deff161 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2025-03-22 12:16:03 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2025-03-22 14:15:49 +0000 app-admin/eselect: add 1.4.30 Closes: https://bugs.gentoo.org/951499 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-admin/eselect/Manifest | 1 + app-admin/eselect/eselect-1.4.30.ebuild | 61 +++++++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+) |
