Bug 95132 – ndiswrapper won't compile with recent suspend2 enabled kernel

• Product: Gentoo Linux
• Status: RESOLVED DUPLICATE

[Description Roland Hagemann 2005-06-05 09:25:17 UTC]

The option in the kernel .config file for Software Suspend 2
(http://www.suspend2.net) has recently changed from CONFIG_SOFTWARE_SUSPEND2 to
CONFIG_SUSPEND2 which leads to the following error when emerging ndiswrapper-1.1-r1

/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.c:1112:68:
macro "kthread_run" requires 5 arguments, but only 3 given
/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.c: In
function `PsCreateSystemThread':
/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.c:1112:
error: `kthread_run' undeclared (first use in this function)
/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.c:1112:
error: (Each undeclared identifier is reported only once
/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.c:1112:
error: for each function it appears in.)
make[2]: ***
[/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver/ntoskernel.o]
Error 1
make[1]: ***
[_module_/var/tmp/portage/ndiswrapper-1.1-r1/work/ndiswrapper-1.1/driver] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.11.11'
make: *** [default] Error 2

I suggest the following (trivial) patch

--- ntoskernel-new.h    2005-06-05 18:23:43.000000000 +0200
+++ ntoskernel.h        2005-04-12 15:53:46.000000000 +0200
@@ -170,7 +170,7 @@

 #endif // LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)

-#ifdef CONFIG_SUSPEND2
+#ifdef CONFIG_SOFTWARE_SUSPEND2
 #define KTHREAD_RUN(a,b,c) kthread_run(a,b,0,c)
 #else
 #define KTHREAD_RUN(a,b,c) kthread_run(a,b,c)

Reproducible: Always
Steps to Reproduce:

[Comment 1 Roland Hagemann 2005-06-05 09:27:37 UTC]

Whoops, wrong order when calling diff. I'm sure you can figure it out ;-)

[Comment 2 Henrik Brix Andersen 2005-06-05 14:34:58 UTC]

Actually it should be '#ifdef PF_SYNCTHREAD'

[Comment 3 Doug Goldstein (RETIRED) 2005-06-06 22:31:58 UTC]

*** This bug has been marked as a duplicate of 92925 ***