Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 949965

Summary: app-misc/ddccontrol-1.0.3: sed: can't read src/ddcpci/Makefile.ini: No such file or directory
Product: Gentoo Linux Reporter: benoit.dufour
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal CC: benoit.dufour, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log

Description benoit.dufour 2025-02-19 15:21:10 UTC
Created attachment 919370 [details]
build.log

I tried to build it on my ARM64 workstation.
It didn't work since it is unable to find the Makefile.ini file,
but it did build correctly on my AMD64 computers.
Comment 1 benoit.dufour 2025-05-10 00:31:35 UTC
I took at look at the ebuild and it appears to me the src_prepare function is causing the issue. And I believe it would happen on any other platform than x86 and amd64:
	# ppc/ppc64 do not have inb/outb/ioperm
	# they also do not have (sys|asm)/io.h
	if ! use amd64 && ! use x86 ; then
        [...]

It seems to me that patch causing the issue was specifically made for ppc/ppc64, and if it's not relevant for other arches like arm/arm64, it should be instead:
	# ppc/ppc64 do not have inb/outb/ioperm
	# they also do not have (sys|asm)/io.h
	"if use ppc || use ppc64 ; then"

Here's the list of files in work/ddccontrol-1.0.3:
tux ~ # 
ls -l /var/tmp/portage/app-misc/ddccontrol-1.0.3/work/ddccontrol-1.0.3
total 88
-rw-r--r-- 1 portage portage   240 31 janv.  2024 AUTHORS
-rwxr-xr-x 1 portage portage   131 31 janv.  2024 autogen.sh
-rw-r--r-- 1 portage portage  2299 31 janv.  2024 CHANGELOG.md
-rw-r--r-- 1 portage portage  1462 31 janv.  2024 CheckList
-rwxr-xr-x 1 portage portage   470 31 janv.  2024 commit.sh
-rw-r--r-- 1 portage portage  8706 31 janv.  2024 configure.ac
-rw-r--r-- 1 portage portage 18092 31 janv.  2024 COPYING
drwxr-xr-x 2 portage portage  4096 31 janv.  2024 doc
-rw-r--r-- 1 portage portage   286 31 janv.  2024 Makefile.am
drwxr-xr-x 2 portage portage  4096 31 janv.  2024 man
-rw-r--r-- 1 portage portage  2307 31 janv.  2024 NEWS
drwxr-xr-x 2 portage portage  4096 31 janv.  2024 po
-rw-r--r-- 1 portage portage  3286 31 janv.  2024 README.md
drwxr-xr-x 3 portage portage  4096 31 janv.  2024 scripts
drwxr-xr-x 7 portage portage  4096 31 janv.  2024 src
-rw-r--r-- 1 portage portage   513 31 janv.  2024 TODO
tux ~ # 

So there's definitly no Makefile.ini file, and so maybe the ebuild never got updated to take account of the removal of that file or of changes in the build system.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-05-10 00:48:55 UTC
In...

commit e620abbc937619f3d69896ff4d7ace2696bc0c93
Author: Manuel Rüger <mrueg@gentoo.org>
Date:   Wed Jul 10 09:46:16 2013 +0000

    Non-maintainer commit: Add support for fglrx (AMD ADL). Fix desktop file. See bug #475568

    (Portage version: 2.1.12.13/cvs/Linux x86_64, signed Manifest commit with key )

... .in gets changed to .ini, which seems weird.

The line itself goes back to:

commit 3255c2e57a7c24147aa50ca7cf9603211e790e9a
Author: Robin H. Johnson <robbat2@gentoo.org>
Date:   Sun Jul 15 07:44:37 2007 +0000

    Bug #163057 - compile fix for zlib'd pciutils. Also fix compile on ppc for in/out/ioperm usage.
    (Portage version: 2.1.3_rc8)

Back then, it was:

+       if [ "${ARCH/64}" == "ppc" ]; then

It changed to the current arch check with:

commit 5cb6622ff2a100c12d020f1d03bf25ac9670e072
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Wed Jan 25 02:17:34 2012 +0000

    Migrate to EAPI=4, fix build with newer automake with patch from upstream, add USE=static-libs support, and add USE=ddcpci to control the setuid binary.

    (Portage version: 2.2.0_alpha84/cvs/Linux x86_64)

In any case, let's just drop it and see what happens.
Comment 3 Larry the Git Cow gentoo-dev 2025-05-10 00:51:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e16a6f093a3a974a79f39308dc6bcdd2592f942

commit 3e16a6f093a3a974a79f39308dc6bcdd2592f942
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2025-05-10 00:50:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-05-10 00:50:21 +0000

    app-misc/ddccontrol: drop broken sed on non-amd64/x86
    
    In...
    
    commit e620abbc937619f3d69896ff4d7ace2696bc0c93
    Author: Manuel Rüger <mrueg@gentoo.org>
    Date:   Wed Jul 10 09:46:16 2013 +0000
    
        Non-maintainer commit: Add support for fglrx (AMD ADL). Fix desktop file. See bug #475568
    
        (Portage version: 2.1.12.13/cvs/Linux x86_64, signed Manifest commit with key )
    
    ... .in gets changed to .ini, which seems weird.
    
    The line itself goes back to:
    
    commit 3255c2e57a7c24147aa50ca7cf9603211e790e9a
    Author: Robin H. Johnson <robbat2@gentoo.org>
    Date:   Sun Jul 15 07:44:37 2007 +0000
    
        Bug #163057 - compile fix for zlib'd pciutils. Also fix compile on ppc for in/out/ioperm usage.
        (Portage version: 2.1.3_rc8)
    
    Back then, it was:
    
    +       if [ "${ARCH/64}" == "ppc" ]; then
    
    It changed to the current arch check with:
    
    commit 5cb6622ff2a100c12d020f1d03bf25ac9670e072
    Author: Mike Frysinger <vapier@gentoo.org>
    Date:   Wed Jan 25 02:17:34 2012 +0000
    
        Migrate to EAPI=4, fix build with newer automake with patch from upstream, add USE=static-libs support, and add USE=ddcpci to control the setuid binary.
    
        (Portage version: 2.2.0_alpha84/cvs/Linux x86_64)
    
    In any case, let's just drop it and see what happens. Especially given
    it's been broken for non-amd64 + x86 (which is the case it's supposed
    to help with) for several months at the very least.
    
    Closes: https://bugs.gentoo.org/949965
    Signed-off-by: Sam James <sam@gentoo.org>

 app-misc/ddccontrol/ddccontrol-1.0.3.ebuild | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)