| Summary: | sys-process/atop-2.11.0: USE=module fails to build with -Werror=strict-prototypes | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | NHO <jy6x2b32pie9> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jy6x2b32pie9 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 880545 | ||
| Attachments: | build log | ||
Fix for prototypes is trivial - they are with (void), but definitions with empty braces. Fix for fallthrough is... not. It feels like false positive. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d98d4d103b34e15df6b3ac9902a945d2336fc5c8 commit d98d4d103b34e15df6b3ac9902a945d2336fc5c8 Author: NHOrus <jy6x2b32pie9@yahoo.com> AuthorDate: 2025-02-16 11:58:23 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-02-16 12:04:17 +0000 sys-process/atop: fix build for USE=modules netatop is separate source base that thankfully has right declarations but bad definitions. Patching definitions, but only when USE=modules Closes: https://bugs.gentoo.org/949835 Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com> Closes: https://github.com/gentoo/gentoo/pull/40593 Signed-off-by: Sam James <sam@gentoo.org> sys-process/atop/atop-2.11.0-r1.ebuild | 1 + .../files/netatop-3.2.2-strict-prototype.patch | 77 ++++++++++++++++++++++ 2 files changed, 78 insertions(+) |
Created attachment 919061 [details] build log netatop.c:1056:11: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1056 | gctaskexit() | ^ | void netatop.c:1090:11: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1090 | gcsockinfo() | ^ | void netatop.c:1303:11: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1303 | gctaskinfo() | ^ | void netatop.c:1379:13: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1379 | wipesockinfo() | ^ | void netatop.c:1407:13: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1407 | wipetaskinfo() | ^ | void netatop.c:1435:13: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1435 | wipetaskexit() | ^ | void netatop.c:1665:6: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] 1665 | case NETATOP_GETCNT_PID: | ^ netatop.c:1665:6: note: insert '__attribute__((fallthrough));' to silence this warning 1665 | case NETATOP_GETCNT_PID: | ^ | __attribute__((fallthrough)); netatop.c:1665:6: note: insert 'break;' to avoid fall-through 1665 | case NETATOP_GETCNT_PID: | ^ | break; netatop.c:1771:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1771 | init_module() | ^ | void netatop.c:1872:15: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] 1872 | cleanup_module() | ^ | void 1 warning and 8 errors generated.