| Summary: | media-sound/strawberry: loudness useflag is now pointless | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | David Flogeras <dflogeras2> |
| Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fordfrog |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=925505 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
|
Description
David Flogeras
2025-01-18 11:49:40 UTC
so it seems the fix i did is not correct as when building without loudness use flag, strawberry does not link against media-libs/libebur128. so i guess the configuration process should be fixed instead to not check for libebur128 when loudness is disabled. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e737b5fa76b5fd261215e1397ad6344c64193d9 commit 7e737b5fa76b5fd261215e1397ad6344c64193d9 Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2025-01-18 15:12:15 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2025-01-18 15:12:24 +0000 media-sound/strawberry: dropped duplicate dependency Closes: https://bugs.gentoo.org/948345 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/strawberry/strawberry-1.2.2-r1.ebuild | 1 - media-sound/strawberry/strawberry-1.2.5.ebuild | 1 - media-sound/strawberry/strawberry-9999.ebuild | 1 - 3 files changed, 3 deletions(-) i reverted my "fix", it's probably not broken anymore... (In reply to Miroslav Šulc from comment #3) > i reverted my "fix", it's probably not broken anymore... I'm a bit confused now. https://github.com/strawberrymusicplayer/strawberry/blob/ae89ca8123267547a950c994f751e4d3b7605b88/CMakeLists.txt#L193 says to me it *is* still automagic. So I think this reintroduces bug 925505. You should be able to verify that by looking at ELF NEEDED (iwdevtools this for you) with USE=-loudness but with libebur128 installed. I'll reopen the other bug so we don't lose track. |
