Bug 946158

Summary:	www-client/firefox-133.0[-clang,llvm_slot_19] compile failure
Product:	Gentoo Linux	Reporter:	Ulrich Müller <ulm>
Component:	Current packages	Assignee:	Gentoo Rust Project <rust>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mozilla
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=942013 https://bugs.gentoo.org/show_bug.cgi?id=949280
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build.log emerge --info www-client/firefox

Description Ulrich Müller gentoo-dev

2024-12-09 16:53:02 UTC

4:48.78      Running `CARGO=/usr/lib/rust/1.83.0/bin/cargo CARGO_CRATE_NAME=golden_gate CARGO_MANIFEST_DIR=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/services/sync/golden_gate CARGO_MANIFEST_PATH=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/services/sync/golden_gate/Cargo.toml CARGO_PKG_AUTHORS='The Firefox Sync Developers <sync-team@mozilla.com>' CARGO_PKG_DESCRIPTION='A bridge for wiring up Sync engines implemented in Rust' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=golden_gate CARGO_PKG_README='' CARGO_PKG_REPOSITORY='' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH=/tmp/portage/www-client/firefox-133.0/work/firefox_build/release/deps /usr/lib/rust/1.83.0/bin/rustc --crate-name golden_gate --edition=2018 services/sync/golden_gate/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=dc9cf54a30b51d85 -C extra-filename=-dc9cf54a30b51d85 --out-dir /tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/build/cargo-linker -C strip=debuginfo -L dependency=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/portage/www-client/firefox-133.0/work/firefox_build/release/deps --extern anyhow=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libanyhow-9e4cfa86f86a5801.rmeta --extern atomic_refcell=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libatomic_refcell-4a7c5614125dd370.rmeta --extern cstr=/tmp/portage/www-client/firefox-133.0/work/firefox_build/release/deps/libcstr-6f4c8176161878c9.so --extern interrupt_support=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libinterrupt_support-c3a295e65db48ca0.rmeta --extern log=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblog-a7781f52fa8764f0.rmeta --extern moz_task=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libmoz_task-21b47fad545ccf5d.rmeta --extern nserror=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnserror-8403be8f4d1ecd94.rmeta --extern nsstring=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnsstring-8180b76526f09092.rmeta --extern serde_json=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde_json-80dc8a351f8104e9.rmeta --extern storage_variant=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libstorage_variant-3530696806db32dc.rmeta --extern sync15=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libsync15-924ed3d205f357d8.rmeta --extern thin_vec=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libthin_vec-9f60320ed540fb13.rmeta --extern xpcom=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libxpcom-7dcf95398952d026.rmeta -C debuginfo=2 --cap-lints warn -C codegen-units=1`
 4:48.78 rustc: /tmp/portage/dev-lang/rust-1.83.0/work/rustc-1.83.0-src/src/llvm-project/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:298: void llvm::Loc::MMI::addFrameIndexExpr(const llvm::DIExpression*, int): Assertion `(FrameIndexExprs.size() == 1 || llvm::all_of(FrameIndexExprs, [](const FrameIndexExpr &FIE) { return FIE.Expr && FIE.Expr->isFragment(); })) && "conflicting locations for variable"' failed.
 4:48.78 warning: unexpected `cfg` condition value: `full-sync`
 4:48.78   --> /tmp/portage/www-client/firefox-133.0/work/firefox-133.0/third_party/rust/tabs/src/error.rs:28:11
 4:48.78    |
 4:48.79 28 |     #[cfg(feature = "full-sync")]
 4:48.79    |           ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition
 4:48.79    |
 4:48.79    = note: no expected values for `feature`
 4:48.79    = help: consider adding `full-sync` as a feature in `Cargo.toml`
 4:48.79    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
 4:48.79    = note: `#[warn(unexpected_cfgs)]` on by default
 4:48.79 warning: unexpected `cfg` condition value: `full-sync`
 4:48.79   --> /tmp/portage/www-client/firefox-133.0/work/firefox-133.0/third_party/rust/tabs/src/error.rs:35:15
 4:48.79    |
 4:48.79 35 |     #[cfg(not(feature = "full-sync"))]
 4:48.79    |               ^^^^^^^^^^^^^^^^^^^^^ help: remove the condition
 4:48.79    |
 4:48.79    = note: no expected values for `feature`
 4:48.79    = help: consider adding `full-sync` as a feature in `Cargo.toml`
 4:48.80    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
 4:48.80 warning: `authenticator` (lib) generated 6 warnings
 4:48.80 error: could not compile `authenticator` (lib); 6 warnings emitted
 4:48.80 Caused by:
 4:48.83   process didn't exit successfully: `CARGO=/usr/lib/rust/1.83.0/bin/cargo CARGO_CRATE_NAME=authenticator CARGO_MANIFEST_DIR=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/third_party/rust/authenticator CARGO_MANIFEST_PATH=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/third_party/rust/authenticator/Cargo.toml CARGO_PKG_AUTHORS='Dana Keeler <dkeeler@mozilla.com>:J.C. Jones <jc@mozilla.com>:John Schanck <jschanck@mozilla.com>:Kyle Machulis <kyle@nonpolynomial.com>:Martin Sirringhaus <martin.sirringhaus@suse.com:Tim Taubert <ttaubert@mozilla.com>' CARGO_PKG_DESCRIPTION='Library for interacting with CTAP1/2 security keys for Web Authentication. Used by Firefox.' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=authenticator CARGO_PKG_README=README.md CARGO_PKG_REPOSITORY='https://github.com/mozilla/authenticator-rs/' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.4.1 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=4 CARGO_PKG_VERSION_PATCH=1 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH=/tmp/portage/www-client/firefox-133.0/work/firefox_build/release/deps OUT_DIR=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/build/authenticator-a6d26d302db177b8/out /usr/lib/rust/1.83.0/bin/rustc --crate-name authenticator --edition=2018 /tmp/portage/www-client/firefox-133.0/work/firefox-133.0/third_party/rust/authenticator/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --cfg 'feature="crypto_nss"' --cfg 'feature="default"' --cfg 'feature="gecko"' --cfg 'feature="nss-gk-api"' --cfg 'feature="pkcs11-bindings"' --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values("bindgen", "binding-recompile", "bytes", "crypto_dummy", "crypto_nss", "crypto_openssl", "default", "gecko", "nss-gk-api", "openssl", "openssl-sys", "pkcs11-bindings"))' -C metadata=3b9e00b19555894d -C extra-filename=-3b9e00b19555894d --out-dir /tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -C linker=/tmp/portage/www-client/firefox-133.0/work/firefox-133.0/build/cargo-linker -C strip=debuginfo -L dependency=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/portage/www-client/firefox-133.0/work/firefox_build/release/deps --extern base64=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libbase64-a25c153497ba748b.rmeta --extern bitflags=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libbitflags-67c036afa28e1d2a.rmeta --extern cfg_if=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libcfg_if-a1a2b0cf5b6f73b5.rmeta --extern libc=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblibc-d9dbcc834e5d2bdc.rmeta --extern libudev=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblibudev-1e5547fecd8c4a50.rmeta --extern log=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/liblog-a7781f52fa8764f0.rmeta --extern nss_gk_api=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libnss_gk_api-3849021d1cdf62a3.rmeta --extern pkcs11_bindings=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libpkcs11_bindings-1711a79cbf884764.rmeta --extern rand=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/librand-a09a381419cdcfb7.rmeta --extern runloop=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/librunloop-4c0e1be1bb6d5e45.rmeta --extern serde=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde-dd0f323f1d4ecf4d.rmeta --extern serde_bytes=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde_bytes-a83d552d663e9393.rmeta --extern serde_cbor=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde_cbor-2a2bea2d0f8ae41a.rmeta --extern serde_json=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libserde_json-80dc8a351f8104e9.rmeta --extern sha2=/tmp/portage/www-client/firefox-133.0/work/firefox_build/x86_64-unknown-linux-gnu/release/deps/libsha2-d01dfebf74fd075c.rmeta --cap-lints warn -C debuginfo=2 --cap-lints warn -C codegen-units=1 -L native=/tmp/portage/www-client/firefox-133.0/work/firefox_build/dist/bin -L native=/tmp/portage/www-client/firefox-133.0/work/firefox_build/security/nss/lib/nss/nss_nss3 -L native=/tmp/portage/www-client/firefox-133.0/work/firefox_build/security/nss/lib/ssl/ssl_ssl3 -L native=/tmp/portage/www-client/firefox-133.0/work/firefox_build/config/external/nspr/pr` (signal: 6, SIGABRT: process abort signal)
 4:48.83 warning: build failed, waiting for other jobs to finish...
 [...]
 * ERROR: www-client/firefox-133.0::gentoo failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 136:  Called src_compile
 *   environment, line 5331:  Called die
 * The specific snippet of code:
 *       ${virtx_cmd} ./mach build --verbose || die

Comment 1 Ulrich Müller gentoo-dev

2024-12-09 16:58:37 UTC

Created attachment 913657 [details]
build.log

Comment 2 Ulrich Müller gentoo-dev

2024-12-09 16:59:29 UTC

Created attachment 913658 [details]
emerge --info www-client/firefox

Comment 3 Joonas Niilola gentoo-dev

2024-12-09 18:19:47 UTC

(always disable ccache first when you encounter a compile error)

but it's https://bugs.gentoo.org/942013 again. Upstream hasn't merged the patch for rust-1.83 - and of course the patch used in 1.82 itself doesn't apply cleanly anymore.

Comment 4 Joonas Niilola gentoo-dev

2024-12-09 18:34:25 UTC

Could you drop this into /etc/portage/patches - recompile rust with it, and try again?

https://github.com/rust-lang/rust/commit/1dc106121b62562ead6e7d612fa136dc4b35cd5d.patch

Comment 5 Ulrich Müller gentoo-dev

2024-12-09 22:07:58 UTC

(In reply to Joonas Niilola from comment #4)
> Could you drop this into /etc/portage/patches - recompile rust with it, and
> try again?
> 
> https://github.com/rust-lang/rust/commit/
> 1dc106121b62562ead6e7d612fa136dc4b35cd5d.patch

This patch fixes the firefox build failure for me.

Comment 6 Larry the Git Cow gentoo-dev

2024-12-10 07:22:15 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=418188d532488b5ecfeaf19e938bed3f1aaa6d15

commit 418188d532488b5ecfeaf19e938bed3f1aaa6d15
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2024-12-10 07:20:00 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-12-10 07:20:00 +0000

    dev-lang/rust: fix LLVM assertion with debug info in 1.83.0
    
     - the patch is rebased for 1.83, but merged upstream to 1.84.
    
    Closes: https://bugs.gentoo.org/946158
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../rust/files/1.83.0-dwarf-llvm-assertion.patch   | 242 +++++++++++++++++++++
 .../{rust-1.83.0.ebuild => rust-1.83.0-r1.ebuild}  |   1 +
 2 files changed, 243 insertions(+)

Comment 7 Joonas Niilola gentoo-dev

2024-12-10 07:23:36 UTC

(In reply to Ulrich Müller from comment #5)
> 
> This patch fixes the firefox build failure for me.

You should package.mask rust-1.83.0-r1 locally :)